Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"var.enable_gluesync" is broken #167

Open
barnharts4 opened this issue Jul 1, 2020 · 0 comments
Open

"var.enable_gluesync" is broken #167

barnharts4 opened this issue Jul 1, 2020 · 0 comments
Labels
bug Something isn't working good first issue Good for newcomers

Comments

@barnharts4
Copy link
Contributor

Describe the bug
Behavior of var.enable_gluesync is broken.

  • In ECS, setting enable_gluesync to false will still trigger HMS docker image to use glue sync, but the IAM policy is not created, so it fails.
  • In K8S, the env var ENABLE_GLUESYNC is never passed to the HMS docker image, so enabling glue sync doesn't work.

Additional context

  • The ECS issue is because when TF vars were change to boolean instead of strings, the value for false gets passed to ENABLE_GLUESYNC as false. But the startup.sh code in the docker image does a if [ !-z $ENABLE_GLUESYNC ] check, which sees the value false as non-empty, so enables glue sync. For the correct way of fixing this, see how enable_metrics is being set in https://github.com/ExpediaGroup/apiary-data-lake/blob/master/templates.tf#L24.
  • The K8S issue looks like an oversight of passing the correct value to ENABLE_GLUESYNC.
@barnharts4 barnharts4 added bug Something isn't working good first issue Good for newcomers labels Jul 1, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

1 participant