From ea901e4fdc25724b6615a69bdb0a7d3a9ab74170 Mon Sep 17 00:00:00 2001
From: javsanbel2 <javiersb1997@gmail.com>
Date: Tue, 3 Dec 2024 11:37:32 +0000
Subject: [PATCH] fix tf bug

---
 s3.tf | 7 +++++--
 1 file changed, 5 insertions(+), 2 deletions(-)

diff --git a/s3.tf b/s3.tf
index 7b34763..aec0a0f 100644
--- a/s3.tf
+++ b/s3.tf
@@ -89,23 +89,26 @@ resource "aws_s3_bucket_lifecycle_configuration" "apiary_data_bucket_versioning_
     for schema in local.schemas_info : "${schema["schema_name"]}" => schema
   }
   bucket = each.value["data_bucket"]
+  # Rule only enabled when expiration days are set
   rule {
     id     = "expire-noncurrent-versions-days"
-    status = lookup(each.value, "noncurrent_version_expiration_days", "") != "" ? "Enabled" : "Disabled"
+    status = lookup(each.value, "noncurrent_version_expiration_days", "") != "" && lookup(each.value, "newer_noncurrent_versions", "") == "" ? "Enabled" : "Disabled"
 
     noncurrent_version_expiration {
       noncurrent_days = tonumber(lookup(each.value, "s3_noncurrent_version_expiration_days", var.noncurrent_version_expiration_days))
     }
   }
+  # Rule enabled when expiration days and versions are set
   rule {
     id     = "expire-noncurrent-versions-number"
     status = lookup(each.value, "newer_noncurrent_versions", "") != "" ? "Enabled" : "Disabled"
 
     noncurrent_version_expiration {
       newer_noncurrent_versions = tonumber(lookup(each.value, "newer_noncurrent_versions", var.newer_noncurrent_versions))
+      noncurrent_days           = tonumber(lookup(each.value, "s3_noncurrent_version_expiration_days", var.noncurrent_version_expiration_days))
     }
   }
-}
+} 
 
 resource "aws_s3_bucket_inventory" "apiary_bucket" {
   for_each = var.s3_enable_inventory == true ? {