From 085f4cfa8b4f7693bf47a560f31c8ca5d40ae8c5 Mon Sep 17 00:00:00 2001
From: githubjianli <51385385+githubjianli@users.noreply.github.com>
Date: Mon, 26 Aug 2024 15:02:02 -0700
Subject: [PATCH] fix: fixing s3 inventory service account secret (#271)

Co-authored-by: janli <janli@expediagroup.com>
---
 CHANGELOG.md            | 4 ++++
 k8s-service-accounts.tf | 4 ++--
 2 files changed, 6 insertions(+), 2 deletions(-)

diff --git a/CHANGELOG.md b/CHANGELOG.md
index fb0e130..af58828 100644
--- a/CHANGELOG.md
+++ b/CHANGELOG.md
@@ -3,6 +3,10 @@ All notable changes to this project will be documented in this file.
 
 The format is based on [Keep a Changelog](http://keepachangelog.com/en/1.0.0/) and this project adheres to [Semantic Versioning](http://semver.org/spec/v2.0.0.html).
 
+## [7.3.1] - 2024-08-26
+### Fixed
+- Fixed incorrect `s3-inventory` service account secret binding.
+
 ## [7.3.0] - 2024-08-20
 ### Added
 - If apiary_managed_schemas has `deny_global_write_access` enabled, only `producer_roles` will be able to write in the specified schema.
diff --git a/k8s-service-accounts.tf b/k8s-service-accounts.tf
index c1dba95..35176e7 100644
--- a/k8s-service-accounts.tf
+++ b/k8s-service-accounts.tf
@@ -65,10 +65,10 @@ resource "kubernetes_service_account_v1" "s3_inventory" {
 
 resource "kubernetes_secret_v1" "s3_inventory" {
   metadata {
-    name        = "${local.hms_alias}-s3-inventory"
+    name        = "${local.instance_alias}-s3-inventory"
     namespace   = var.metastore_namespace
     annotations = {
-      "kubernetes.io/service-account.name"      ="${local.hms_alias}-s3-inventory"
+      "kubernetes.io/service-account.name"      ="${local.instance_alias}-s3-inventory"
       "kubernetes.io/service-account.namespace" = var.metastore_namespace
     }
   }