Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor frontend to use modules rather than /pages file #114

Open
Exilliar opened this issue Feb 3, 2020 · 3 comments
Open

refactor frontend to use modules rather than /pages file #114

Exilliar opened this issue Feb 3, 2020 · 3 comments
Labels
refactor major refactor that will likely take longer than a regular issue

Comments

@Exilliar
Copy link
Owner

Exilliar commented Feb 3, 2020

ask Craig if confused
@Exilliar Exilliar added the refactor major refactor that will likely take longer than a regular issue label Feb 3, 2020
@Exilliar
Copy link
Owner Author

Exilliar commented Feb 6, 2020

1st step will be to change the films table to be it's own component

Exilliar added a commit that referenced this issue Feb 16, 2020
@Exilliar
#114 replaced pages file with each page having it's own module so tha…
7c27e46 
…t lazy loading can be used. Still need to convert to using smart and dumb components, currently all components are containers. Also moved guards, services, and some components to a /core file
@Exilliar
Copy link
Owner Author

Exilliar commented Feb 16, 2020 •
edited
Loading

steps to complete issue

  • 1. find which modules and services are only used by one page, move them into the correct module
  • 2. make the table component for blurays into a component in core that the viewtable component can also use
  • 3. make login and register components have dummy components, possibly find a way to make them use the same dummy component (not sure if that will be useful)
  • 4. make admin page have dummy and smart component, table should be in dummy component (maybe look into using same component at the blurays table)

Will add more to the issue as are found. Commits should be made after solving each task in this, and following, comments

@Exilliar
Copy link
Owner Author

Exilliar added a commit that referenced this issue Feb 29, 2020
@Exilliar
#114 part 1. completed. Only 1 service to move, maybe suggests that t…
5530745 
…he services have not been created well?
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
refactor major refactor that will likely take longer than a regular issue
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@Exilliar