-
Notifications
You must be signed in to change notification settings - Fork 17
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Public vs internal types for UDFs #37
Comments
I now see the comment in Excel-DNAs AssemblyLoader:
So I'm assuming you don't want to introduce this to ExcelDnaDoc as well. |
I think the UDFs considered should match. I don't know whether the ExcelDnaDoc takes the ExcplictExports directive into account, but it probably should. |
Excel-DNA uses .GetTypes() with the comment mentioned above, while ExcelDnaDoc uses .GetExportedTypes(), so there is a discrepancy. The fact I want ExcelDnaDoc to use .GetTypes() as well might indicate bad programming on my part :-) |
-- Edited, reworded because I was mixing up concepts ---
Hi,
Would you consider changing the types whose public methods are considered applicable for ExcelFunctionDoc etc from GetExportedTypes to GetTypes, so public methods from internal types are considered as well?
ExcelDna itself allows UDFs to be in internal types, so the behavior would be the same.
I myself have a class hierarchy that should not be completely exposed as public, hence my question.
Regards,
Sascha
The text was updated successfully, but these errors were encountered: