Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Normalize card names #8

Open
Everlag opened this issue Dec 11, 2015 · 1 comment
Open

Normalize card names #8

Everlag opened this issue Dec 11, 2015 · 1 comment

Comments

@Everlag
Copy link
Owner

Everlag commented Dec 11, 2015

Currently, cards which contain non-ascii characters, such as Séance or Æther Vial, possess inconsistent names across the static and dynamic endpoints.

Using Æther Vial as an example,

The fact that the price lookup completely fails for mtgprice in every case means that we cannot just tell the client to smooth our edge cases.

@Everlag
Copy link
Owner Author

Everlag commented Dec 13, 2015

Another facet of the Æther Vial problem is that a full set query for Modern Masters returns the card with the mtgprice 'AEther Vial' name rather than the official.

At which point do we normalize names? Intake in priceWriter or output in price api?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant