Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix docs build #413

Merged
merged 1 commit into from
Oct 8, 2024
Merged

Fix docs build #413

merged 1 commit into from
Oct 8, 2024

Conversation

George-Payne
Copy link
Member

@George-Payne George-Payne commented Oct 8, 2024

Our docs site generation has been broken for a while, as we've been waiting for a few stencil fixes:

Typescript strict fix: ionic-team/stencil#5959
Hydrate app globals fix: ionic-team/stencil#6005

Unfortunately there's a new bug with copy tasks, so I had to patch in a fix. We can update and get rid of this if ionic-team/stencil#6020 is merged / released.

Additionally, I had to increase node's available stack size for pre-rendering, as the docs site grows.

- update stencil to 4.22.0 for fixes
- patch for copy fix
- tweak polyfill file
- increase available stack size for pre-rendering
@George-Payne George-Payne self-assigned this Oct 8, 2024
@George-Payne George-Payne requested a review from teamchong October 8, 2024 16:20
@George-Payne George-Payne added the documentation Improvements or additions to documentation label Oct 8, 2024
Copy link
Contributor

@teamchong teamchong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works for me. I didn’t test it extensively, but it builds and serves on my machine.

@George-Payne George-Payne merged commit f216aa2 into main Oct 8, 2024
2 checks passed
@George-Payne George-Payne deleted the fix-docs branch October 8, 2024 17:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants