Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

global.css inconsistent custom properties for light/dark themes #1090

Open
tomasohCHOM opened this issue Jun 4, 2024 · 0 comments
Open

global.css inconsistent custom properties for light/dark themes #1090

tomasohCHOM opened this issue Jun 4, 2024 · 0 comments
Labels
bug Something isn't working

Comments

@tomasohCHOM
Copy link
Collaborator

What happened?

/static/global.css defines all the custom properties used across the entire website. However, it can be confusing to distinguish the value of the properties based on whether light or dark theme is on. For example, the properties --acm-dark and --acm-light are actually switched depending on the website's current theme.

To fix this, we could rename these properties (and all the references across the entire codebase) using more general terms for the theme properties, such as --acm-primary, or --acm-contrast, instead of --acm-dark or --acm-light.

@tomasohCHOM tomasohCHOM added the bug Something isn't working label Jun 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant