Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Table: update test code that uses the internals of the pagination component #9483

Open
driskull opened this issue May 31, 2024 · 0 comments
Open

Table: update test code that uses the internals of the pagination component #9483

driskull opened this issue May 31, 2024 · 0 comments
Labels
0 - new New issues that need assignment. estimate - 5 A few days of work, definitely requires updates to tests. p - high Issue should be addressed in the current milestone, impacts component or core functionality testing Issues related to automated or manual testing.
Milestone
2025-01-30 - 3.0....

Comments

@driskull
Copy link
Member

Priority impact

p - high

Test type

Update test

Which Component(s)

table

Unstable Tests

See https://github.com/Esri/calcite-design-system/pull/9479/files#diff-1bf108b643e59364f0f72c3c8f4261323c69ab0a7e3cc94c16f70d0ebeca632d

Test error, if applicable

No response

PR skipped, if applicable

Additional Info

The table tests rely on internals of the pagination component. If the internals of the pagination component change then these tests will break. We should update the table test to not rely on internals of other components.
@driskull driskull added testing Issues related to automated or manual testing. 0 - new New issues that need assignment. needs milestone Planning workflow - pending milestone assignment, has priority and/or estimate. labels May 31, 2024
@driskull driskull mentioned this issue May 31, 2024
Merged
@github-actions github-actions bot added the p - high Issue should be addressed in the current milestone, impacts component or core functionality label May 31, 2024
@geospatialem geospatialem removed the needs milestone Planning workflow - pending milestone assignment, has priority and/or estimate. label Aug 7, 2024
@geospatialem geospatialem added this to the 2024-10-29 - Oct Release milestone Aug 7, 2024
@geospatialem geospatialem added the estimate - 5 A few days of work, definitely requires updates to tests. label Oct 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
0 - new New issues that need assignment. estimate - 5 A few days of work, definitely requires updates to tests. p - high Issue should be addressed in the current milestone, impacts component or core functionality testing Issues related to automated or manual testing.
Projects
None yet
Milestone
2025-01-30 - 3.0.0 Jan Breaking Chang...
Development

No branches or pull requests
2 participants
@driskull @geospatialem