Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Carousel] Carousel Items shouldn't animate when using Home / End and destination Carousel Item is currently active #9471

Closed
2 of 6 tasks
macandcheese opened this issue May 30, 2024 · 2 comments
Closed
2 of 6 tasks

[Carousel] Carousel Items shouldn't animate when using Home / End and destination Carousel Item is currently active #9471

macandcheese opened this issue May 30, 2024 · 2 comments
Assignees
@geospatialem @DitwanP
Labels
4 - verified Issues that have been released and confirmed resolved. bug Bug reports for broken functionality. Issues should include a reproduction of the bug. c-carousel Issues that pertain to the calcite-carousel component Calcite (design) Issues logged by Calcite designers. calcite-components Issues specific to the @esri/calcite-components package. estimate - 2 Small fix or update, may require updates to tests. impact - p3 - not time sensitive User set priority impact status of p3 - not time sensitive p - low Issue is non core or affecting less that 10% of people using the library
Milestone
2024-07-31 - Jul ...

Comments

@macandcheese
Copy link
Contributor

macandcheese commented May 30, 2024 •
edited
Loading

Check existing issues

Actual Behavior

When the Carousel component is focused, and keyboard is used to navigate with Home and End - the component should not animate if the currently active Carousel Item is first, or last, and matches the destination.

The behavior should match the behavior of clicking on a currently active Carousel Item's representative "dot", or using the Space or Enter key on a currently active Carousel Item's representative "dot".

Expected Behavior

If the currently active Carousel Item is first, and a user navigates with Home, or the currently active Carousel item is last, and a user navigates with End, the animation should not play.

Screen.Recording.2024-05-30.at.2.12.16.PM.mov

Reproduction Sample

https://codepen.io/mac_and_cheese/pen/pomRYPd?editors=100

Reproduction Steps

  1. Open Codepen
  2. Focus the Carousel component, and use Home / End while the first / last Carousel Item are already active.
  3. Notice the animation occurs.
  4. Try to "re-activate" an active Carousel Item by clicking the dot, or using Space / Enter on the active dot, and notice the animation (correctly) does not occur.

Reproduction Version

2.9.0

Relevant Info

No response

Regression?

No response

Priority impact

impact - p3 - not time sensitive

Impact

No response

Calcite package

  • @esri/calcite-components
  • @esri/calcite-components-angular
  • @esri/calcite-components-react
  • @esri/calcite-design-tokens
  • @esri/eslint-plugin-calcite-components

Esri team

Calcite (design)
@macandcheese macandcheese added bug Bug reports for broken functionality. Issues should include a reproduction of the bug. 0 - new New issues that need assignment. needs triage Planning workflow - pending design/dev review. labels May 30, 2024
@github-actions github-actions bot added the Calcite (design) Issues logged by Calcite designers. label May 30, 2024
@macandcheese macandcheese changed the title [Carousel] Carousel Items shouldn't animate when using keyboard and destination Carousel Item is currently active [Carousel] Carousel Items shouldn't animate when using Home / End and destination Carousel Item is currently active May 30, 2024
@github-actions github-actions bot added calcite-components Issues specific to the @esri/calcite-components package. impact - p3 - not time sensitive User set priority impact status of p3 - not time sensitive labels May 30, 2024
@macandcheese macandcheese self-assigned this May 30, 2024
@geospatialem geospatialem added 1 - assigned Issues that are assigned to a sprint and a team member. and removed 0 - new New issues that need assignment. labels May 31, 2024
@geospatialem geospatialem added p - low Issue is non core or affecting less that 10% of people using the library estimate - 2 Small fix or update, may require updates to tests. labels Jun 10, 2024
@geospatialem geospatialem added this to the 2024-07-30 - Jul Release milestone Jun 10, 2024
@geospatialem geospatialem removed the needs triage Planning workflow - pending design/dev review. label Jun 10, 2024
@macandcheese macandcheese added the c-carousel Issues that pertain to the calcite-carousel component label Jul 2, 2024
@macandcheese macandcheese mentioned this issue Jul 24, 2024
Merged
@macandcheese macandcheese added 2 - in development Issues that are actively being worked on. and removed 1 - assigned Issues that are assigned to a sprint and a team member. labels Jul 24, 2024
macandcheese added a commit that referenced this issue Jul 25, 2024
@macandcheese
fix(carousel): Prevent duplicate animation when navigating via keyboa…
37229a5 
…rd (#9848)

**Related Issue:** #9471

## Summary
When using `home` and `end` while focused on the Container, prevent
"re-navigating" to the currently active Carousel Item and showing a
duplicate animation. This matches the behavior when a user selects an
individual Carousel Item "dot", both with mouse or via keyboard.
@macandcheese macandcheese added 3 - installed Issues that have been merged to master branch and are ready for final confirmation. and removed 2 - in development Issues that are actively being worked on. labels Jul 25, 2024
@github-actions GitHub Actions
Copy link
Contributor

Installed and assigned for verification.

@github-actions github-actions bot assigned DitwanP and unassigned macandcheese Jul 25, 2024
@DitwanP
Copy link
Contributor

DitwanP commented Jul 25, 2024

🍡 Verified on 2.11.0-next.23

@DitwanP DitwanP closed this as completed Jul 25, 2024
@DitwanP DitwanP added 4 - verified Issues that have been released and confirmed resolved. and removed 3 - installed Issues that have been merged to master branch and are ready for final confirmation. labels Jul 25, 2024
calcite-admin pushed a commit that referenced this issue Jul 30, 2024
@macandcheese @github-actions
fix(carousel): Prevent duplicate animation when navigating via keyboa…
cfdbd44 
…rd (#9848)

**Related Issue:** #9471

## Summary
When using `home` and `end` while focused on the Container, prevent
"re-navigating" to the currently active Carousel Item and showing a
duplicate animation. This matches the behavior when a user selects an
individual Carousel Item "dot", both with mouse or via keyboard.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@geospatialem geospatialem

@DitwanP DitwanP

Labels
4 - verified Issues that have been released and confirmed resolved. bug Bug reports for broken functionality. Issues should include a reproduction of the bug. c-carousel Issues that pertain to the calcite-carousel component Calcite (design) Issues logged by Calcite designers. calcite-components Issues specific to the @esri/calcite-components package. estimate - 2 Small fix or update, may require updates to tests. impact - p3 - not time sensitive User set priority impact status of p3 - not time sensitive p - low Issue is non core or affecting less that 10% of people using the library
Projects
None yet
Milestone
2024-07-31 - Jul Release
Development

No branches or pull requests
3 participants
@macandcheese @geospatialem @DitwanP