Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

External content included in dragged list item (Safari only) #9467

Open
2 of 6 tasks
hcampos-professional opened this issue May 30, 2024 · 3 comments
Open
2 of 6 tasks
Labels
0 - new New issues that need assignment. ArcGIS Maps SDK for JavaScript Issues logged by ArcGIS SDK for JavaScript team members. browser-safari Issues tied to the last 2 versions of Safari browser. bug Bug reports for broken functionality. Issues should include a reproduction of the bug. calcite-components Issues specific to the @esri/calcite-components package. impact - p3 - not time sensitive User set priority impact status of p3 - not time sensitive spike Issues that need quick investigations for time estimations, prioritization, or a quick assessment.

Comments

@hcampos-professional
Copy link

hcampos-professional commented May 30, 2024

Check existing issues

Actual Behavior

CleanShot.2024-05-30.at.12.01.09.mp4

When dragging a list item which contains a calcite-action-menu, other content that is not inside of the list item is included in the "ghost" image, but only in Safari. It seems like Safari includes anything within the "bounds" of the dragged element and, because of the action menu being larger, extra content gets included, even if it is not in the list item.

Expected Behavior

The expected behavior is that only elements that are inside of the list item get included in the ghost image. In Chrome/Edge, the behavior is as expected.

Reproduction Sample

https://codesandbox.io/p/sandbox/calcite-nested-list-flickering-forked-zlkpv8?file=%2Findex.html%3A7%2C1

Reproduction Steps

  1. Open https://codepen.io/hccampos/pen/yLWgKJp in Safari
  2. Drag the single list item. Notice that the "OUTSIDE CONTENT" text gets included in the ghost while dragging.

Reproduction Version

2.8.4

Relevant Info

Only happens in Safari (tested with Version 17.5 (19618.2.12.11.6))

Regression?

No response

Priority impact

impact - p3 - not time sensitive

Impact

It impacts the LayerList widget of the ArcGIS Maps SDK, which is used in the ArcGIS SceneViewer and ArcGIS MapViewer, for example.

Calcite package

  • @esri/calcite-components
  • @esri/calcite-components-angular
  • @esri/calcite-components-react
  • @esri/calcite-design-tokens
  • @esri/eslint-plugin-calcite-components

Esri team

ArcGIS Maps SDK for JavaScript

@hcampos-professional hcampos-professional added 0 - new New issues that need assignment. bug Bug reports for broken functionality. Issues should include a reproduction of the bug. needs triage Planning workflow - pending design/dev review. labels May 30, 2024
@github-actions github-actions bot added ArcGIS Maps SDK for JavaScript Issues logged by ArcGIS SDK for JavaScript team members. calcite-components Issues specific to the @esri/calcite-components package. impact - p3 - not time sensitive User set priority impact status of p3 - not time sensitive labels May 30, 2024
@geospatialem geospatialem added the browser-safari Issues tied to the last 2 versions of Safari browser. label May 30, 2024
@driskull
Copy link
Member

Seems to only be happening when the action-menu/group is present.

@hcampos-professional
Copy link
Author

Yes, and the content is only included until the bottom of the action-menu. It really seems like Safari just takes a snapshot of the bounds of the element, without considering whether an element is even visible or part of the element being dragged.

@driskull
Copy link
Member

Yeah, i'll see if there's a workaround otherwise I might have to find a safari bug to link this to or open one.

@geospatialem geospatialem added needs milestone Planning workflow - pending milestone assignment, has priority and/or estimate. spike Issues that need quick investigations for time estimations, prioritization, or a quick assessment. and removed needs triage Planning workflow - pending design/dev review. labels Jun 25, 2024
@geospatialem geospatialem added this to the 2025-03-25 - Mar Release milestone Sep 10, 2024
@geospatialem geospatialem removed the needs milestone Planning workflow - pending milestone assignment, has priority and/or estimate. label Sep 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
0 - new New issues that need assignment. ArcGIS Maps SDK for JavaScript Issues logged by ArcGIS SDK for JavaScript team members. browser-safari Issues tied to the last 2 versions of Safari browser. bug Bug reports for broken functionality. Issues should include a reproduction of the bug. calcite-components Issues specific to the @esri/calcite-components package. impact - p3 - not time sensitive User set priority impact status of p3 - not time sensitive spike Issues that need quick investigations for time estimations, prioritization, or a quick assessment.
Projects
None yet
Development

No branches or pull requests

3 participants