Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Input + Text Area: Add native spellcheck prop #9148

Closed
4 of 9 tasks
geospatialem opened this issue Apr 18, 2024 · 4 comments
Closed
4 of 9 tasks

Input + Text Area: Add native spellcheck prop #9148

geospatialem opened this issue Apr 18, 2024 · 4 comments
Assignees
@geospatialem @DitwanP
Labels
4 - verified Issues that have been released and confirmed resolved. Calcite (dev) Issues logged by Calcite developers. calcite-components Issues specific to the @esri/calcite-components package. enhancement Issues tied to a new feature or request. estimate - 2 Small fix or update, may require updates to tests. good first issue Issues that can be worked on by contributors new to calcite-components. impact - p3 - not time sensitive User set priority impact status of p3 - not time sensitive p - medium Issue is non core or affecting less that 60% of people using the library p4 - not time sensitive User set priority status of p4 - not time sensitive
Milestone
2024-10-29 - Oct ...

Comments

@geospatialem
Copy link
Member

geospatialem commented Apr 18, 2024 •
edited
Loading

Check existing issues

Description

Add spellcheck prop to Text Area, Input, Input Text with a note like this in the doc: https://developer.mozilla.org/en-US/docs/Web/HTML/Global_attributes/spellcheck#security_and_privacy_concerns

Acceptance Criteria

Relevant Info

Requested via ArcGIS resources feedback:

CalciteInputText is missing the property "spellcheck" from the native input-text HTML component! There are instances when the input component do not have to contain dictionary-words (as peculiar street names) and we do not want weird words to be underlined!

Which Component

  • text-area
  • input
  • input-text

Example Use Case

No response

Priority impact

p4 - not time sensitive

Calcite package

  • @esri/calcite-components
  • @esri/calcite-components-angular
  • @esri/calcite-components-react
  • @esri/calcite-design-tokens
  • @esri/eslint-plugin-calcite-components

Esri team

Calcite (dev)
@geospatialem geospatialem added enhancement Issues tied to a new feature or request. 0 - new New issues that need assignment. needs triage Planning workflow - pending design/dev review. labels Apr 18, 2024
@github-actions github-actions bot added Calcite (dev) Issues logged by Calcite developers. calcite-components Issues specific to the @esri/calcite-components package. impact - p3 - not time sensitive User set priority impact status of p3 - not time sensitive labels Apr 18, 2024
@Horiatu
Copy link

Horiatu commented Apr 18, 2024

Just a suggestion: name the attribute nospellcheck so the current code will behave the same with new and old version of components without amending every instance in written code!

@geospatialem geospatialem added good first issue Issues that can be worked on by contributors new to calcite-components. estimate - 2 Small fix or update, may require updates to tests. p - medium Issue is non core or affecting less that 60% of people using the library and removed needs triage Planning workflow - pending design/dev review. p4 - not time sensitive User set priority status of p4 - not time sensitive labels Sep 26, 2024
@anveshmekala anveshmekala self-assigned this Oct 4, 2024
@anveshmekala anveshmekala mentioned this issue Oct 4, 2024
Merged
@anveshmekala anveshmekala added 2 - in development Issues that are actively being worked on. and removed Calcite (dev) Issues logged by Calcite developers. labels Oct 4, 2024
anveshmekala added a commit that referenced this issue Oct 10, 2024
@anveshmekala
feat(input,input-text,text-area): support spellcheck property (#10489)
755bb4c 
**Related Issue:** #9148 

## Summary

Adds support for `spellcheck` property.

`spellcheck` property is a global attribute. Please refer the spec
[here](https://developer.mozilla.org/en-US/docs/Web/HTML/Global_attributes/spellcheck)
@anveshmekala anveshmekala added 3 - installed Issues that have been merged to master branch and are ready for final confirmation. and removed 0 - new New issues that need assignment. 2 - in development Issues that are actively being worked on. labels Oct 10, 2024
@github-actions GitHub Actions
Copy link
Contributor

Installed and assigned for verification.

@github-actions github-actions bot assigned DitwanP and unassigned anveshmekala Oct 10, 2024
@DitwanP
Copy link
Contributor

DitwanP commented Oct 14, 2024

🍠 Verified on 2.14.0-next.13
https://codepen.io/Ditwan-Price/pen/eYqvyzM?editors=1100

@DitwanP DitwanP closed this as completed Oct 14, 2024
@DitwanP DitwanP added 4 - verified Issues that have been released and confirmed resolved. and removed 3 - installed Issues that have been merged to master branch and are ready for final confirmation. labels Oct 14, 2024
@github-actions github-actions bot added the Calcite (dev) Issues logged by Calcite developers. label Nov 18, 2024
@github-actions github-actions bot added the p4 - not time sensitive User set priority status of p4 - not time sensitive label Nov 18, 2024
@geospatialem
Copy link
Member Author

@DitwanP It looks like under the acceptance criteria we have a note to enhance our doc, could you open a new doc issue for us to add context once 3.0 lands WRT:

Update the doc to contain a note similar to https://developer.mozilla.org/en-US/docs/Web/HTML/Global_attributes/spellcheck#security_and_privacy_concerns

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@geospatialem geospatialem

@DitwanP DitwanP

Labels
4 - verified Issues that have been released and confirmed resolved. Calcite (dev) Issues logged by Calcite developers. calcite-components Issues specific to the @esri/calcite-components package. enhancement Issues tied to a new feature or request. estimate - 2 Small fix or update, may require updates to tests. good first issue Issues that can be worked on by contributors new to calcite-components. impact - p3 - not time sensitive User set priority impact status of p3 - not time sensitive p - medium Issue is non core or affecting less that 60% of people using the library p4 - not time sensitive User set priority status of p4 - not time sensitive
Projects
None yet
Milestone
2024-10-29 - Oct Milestone
Development

No branches or pull requests
4 participants
@geospatialem @Horiatu @DitwanP @anveshmekala