Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Shared Close Button mixin #8925

Closed
1 of 5 tasks
alisonailea opened this issue Mar 11, 2024 · 1 comment
Closed
1 of 5 tasks

Shared Close Button mixin #8925

alisonailea opened this issue Mar 11, 2024 · 1 comment
Labels
0 - new New issues that need assignment. calcite-components Issues specific to the @esri/calcite-components package. needs triage Planning workflow - pending design/dev review. refactor Issues tied to code that needs to be significantly reworked.

Comments

@alisonailea
Copy link
Contributor

Description

A lot of components implement a close button. This is a common UI pattern who's user experience and micro interactions should not change across components.

Suggestion. Create a functional mixin similar to the floating panel which allows for style customizations.

Proposed Advantages

Single source of truth for close button interactions and styles.

Which Component

alert, chip, modal, notice, popover, tab-title, combobox, ... others

Relevant Info

No response

Calcite package

  • @esri/calcite-components
  • @esri/calcite-components-angular
  • @esri/calcite-components-react
  • @esri/calcite-design-tokens
  • @esri/eslint-plugin-calcite-components
@alisonailea alisonailea added refactor Issues tied to code that needs to be significantly reworked. 0 - new New issues that need assignment. needs triage Planning workflow - pending design/dev review. labels Mar 11, 2024
@github-actions github-actions bot added the calcite-components Issues specific to the @esri/calcite-components package. label Mar 11, 2024
@jcfranco
Copy link
Member

This looks like a duplicate of #6640.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
0 - new New issues that need assignment. calcite-components Issues specific to the @esri/calcite-components package. needs triage Planning workflow - pending design/dev review. refactor Issues tied to code that needs to be significantly reworked.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@jcfranco @alisonailea