Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Undocumented css custom property in calcite-radio-button needs to be removed #8658

Open
Tracked by #7180
eriklharper opened this issue Jan 26, 2024 · 2 comments
Open
Tracked by #7180

Undocumented css custom property in calcite-radio-button needs to be removed #8658

eriklharper opened this issue Jan 26, 2024 · 2 comments
Labels
1 - assigned Issues that are assigned to a sprint and a team member. breaking change Issues and pull requests with code changes that are not backwards compatible. Calcite (dev) Issues logged by Calcite developers. calcite-components Issues specific to the @esri/calcite-components package. design-tokens Issues requiring design tokens. estimate - 1 Very small fix or change (potentially a single line), doesn't require updates to tests. impact - p1 - need for current milestone User set priority impact status of p1 - need for current milestone needs milestone Planning workflow - pending milestone assignment, has priority and/or estimate. p - low Issue is non core or affecting less that 10% of people using the library p1 - need for current milestone User set priority status of p1 - need for current milestone refactor Issues tied to code that needs to be significantly reworked.

Comments

@eriklharper
Copy link
Contributor

eriklharper commented Jan 26, 2024 •
edited
Loading

The --calcite-radio-size is an undocumented legacy css custom property that is not needed and needs removed.

Relevant Info

This change can be traced back to this commit all the way back in 2021: https://github.com/Esri/calcite-design-system/pull/1696/files

https://codepen.io/eriklharper/pen/XWGzVgB
@eriklharper eriklharper added bug Bug reports for broken functionality. Issues should include a reproduction of the bug. 0 - new New issues that need assignment. needs triage Planning workflow - pending design/dev review. labels Jan 26, 2024
@github-actions github-actions bot added impact - p1 - need for current milestone User set priority impact status of p1 - need for current milestone calcite-components Issues specific to the @esri/calcite-components package. Calcite (dev) Issues logged by Calcite developers. labels Jan 26, 2024
@eriklharper eriklharper changed the title Overriding an undocumented css custom property in calcite-radio-button visually breaks selection state Overriding an undocumented css custom property in calcite-radio-button can visually break selection state Jan 26, 2024
@eriklharper eriklharper self-assigned this Jan 26, 2024
@eriklharper eriklharper added 1 - assigned Issues that are assigned to a sprint and a team member. and removed 0 - new New issues that need assignment. labels Jan 26, 2024
@jcfranco
Copy link
Member

@eriklharper Due to the undocumented nature of the CSS prop, can you update this issue's title and labels to focus more on refactoring vs bug?

@eriklharper eriklharper added refactor Issues tied to code that needs to be significantly reworked. and removed bug Bug reports for broken functionality. Issues should include a reproduction of the bug. labels Jan 29, 2024
@eriklharper eriklharper mentioned this issue Mar 6, 2024
Merged
@geospatialem geospatialem added p - low Issue is non core or affecting less that 10% of people using the library estimate - 1 Very small fix or change (potentially a single line), doesn't require updates to tests. design-tokens Issues requiring design tokens. needs milestone Planning workflow - pending milestone assignment, has priority and/or estimate. and removed needs triage Planning workflow - pending design/dev review. labels Aug 13, 2024
@eriklharper eriklharper changed the title Overriding an undocumented css custom property in calcite-radio-button can visually break selection state Undocumented css custom property in calcite-radio-button needs to be removed Aug 13, 2024
@github-actions github-actions bot added the p1 - need for current milestone User set priority status of p1 - need for current milestone label Aug 13, 2024
@geospatialem geospatialem mentioned this issue Sep 3, 2024
Open
@jcfranco jcfranco added the breaking change Issues and pull requests with code changes that are not backwards compatible. label Nov 22, 2024
@jcfranco
Copy link
Member

Due to the variable name and uncertainty about its current use, we're considering this as a potential breaking change for 4.0.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
1 - assigned Issues that are assigned to a sprint and a team member. breaking change Issues and pull requests with code changes that are not backwards compatible. Calcite (dev) Issues logged by Calcite developers. calcite-components Issues specific to the @esri/calcite-components package. design-tokens Issues requiring design tokens. estimate - 1 Very small fix or change (potentially a single line), doesn't require updates to tests. impact - p1 - need for current milestone User set priority impact status of p1 - need for current milestone needs milestone Planning workflow - pending milestone assignment, has priority and/or estimate. p - low Issue is non core or affecting less that 10% of people using the library p1 - need for current milestone User set priority status of p1 - need for current milestone refactor Issues tied to code that needs to be significantly reworked.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@jcfranco @eriklharper @geospatialem