Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

<calcite-list-item> elements with hidden attributes are visible #8539

Closed
2 of 6 tasks
nwhittaker opened this issue Jan 2, 2024 · 2 comments
Closed
2 of 6 tasks

<calcite-list-item> elements with hidden attributes are visible #8539

nwhittaker opened this issue Jan 2, 2024 · 2 comments
Assignees
@geospatialem @DitwanP
Labels
4 - verified Issues that have been released and confirmed resolved. ArcGIS Field Apps Issues logged by ArcGIS Field Apps team members. bug Bug reports for broken functionality. Issues should include a reproduction of the bug. calcite-components Issues specific to the @esri/calcite-components package. estimate - 3 A day or two of work, likely requires updates to tests. impact - p3 - not time sensitive User set priority impact status of p3 - not time sensitive p - medium Issue is non core or affecting less that 60% of people using the library
Milestone
2024-01-17 - Jan ...

Comments

@nwhittaker
Copy link
Contributor

Check existing issues

Actual Behavior

The <calcite-list-item> elements with hidden attributes are visible.

Expected Behavior

The <calcite-list-item> elements with hidden attributes are hidden.

Reproduction Sample

https://codepen.io/nwhittaker-esri/pen/MWxaLRp

Reproduction Steps

  1. Open the repro sample.
  2. See the hiking trails and waterfall list items are visible despite having hidden attributes.

Reproduction Version

2.1.0

Relevant Info

Spun off from #6544 (comment).

Regression?

No response

Priority impact

p4 - not time sensitive

Impact

No response

Calcite package

  • @esri/calcite-components
  • @esri/calcite-components-angular
  • @esri/calcite-components-react
  • @esri/calcite-design-tokens
  • @esri/eslint-plugin-calcite-components

Esri team

ArcGIS Field Apps
@nwhittaker nwhittaker added bug Bug reports for broken functionality. Issues should include a reproduction of the bug. 0 - new New issues that need assignment. needs triage Planning workflow - pending design/dev review. labels Jan 2, 2024
@github-actions github-actions bot added ArcGIS Field Apps Issues logged by ArcGIS Field Apps team members. calcite-components Issues specific to the @esri/calcite-components package. impact - p3 - not time sensitive User set priority impact status of p3 - not time sensitive labels Jan 2, 2024
@driskull driskull self-assigned this Jan 2, 2024
@driskull driskull added 1 - assigned Issues that are assigned to a sprint and a team member. p - medium Issue is non core or affecting less that 60% of people using the library estimate - 3 A day or two of work, likely requires updates to tests. and removed 0 - new New issues that need assignment. needs triage Planning workflow - pending design/dev review. labels Jan 2, 2024
@driskull driskull added this to the 2024-01-17 - Jan Main Release milestone Jan 2, 2024
driskull added a commit that referenced this issue Jan 2, 2024
@driskull
fix(list, list-item, list-item-group): honor hidden attribute on list…
c488529 
…-item and list-item-group. #8539
@driskull driskull mentioned this issue Jan 2, 2024
Merged
@driskull driskull added 2 - in development Issues that are actively being worked on. and removed 1 - assigned Issues that are assigned to a sprint and a team member. labels Jan 2, 2024
driskull added a commit that referenced this issue Jan 5, 2024
@driskull
fix(list, list-item, list-item-group): honor hidden attribute on list…
3851dc6 
…-item and list-item-group (#8541)

**Related Issue:** #8539

## Summary

- Adds internal `filterHidden` property to `list-item` and
`list-item-group`
- This property is used to hide an item when it is filtered out instead
of the native `hidden` attribute
  - This allows the `hidden` attribute to be set by an end user
- Renames internal vars
- Adds screenshot tests
- Add e2e tests
- Added a developer discussion topic to consider not modifying global
`hidden` attribute on host elements.
@driskull driskull added 3 - installed Issues that have been merged to master branch and are ready for final confirmation. and removed 2 - in development Issues that are actively being worked on. labels Jan 5, 2024
@github-actions github-actions bot assigned geospatialem and DitwanP and unassigned driskull Jan 5, 2024
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jan 5, 2024

Installed and assigned for verification.

@DitwanP
Copy link
Contributor

DitwanP commented Jan 8, 2024

🍠 Verified locally on main

@DitwanP DitwanP closed this as completed Jan 8, 2024
@DitwanP DitwanP added 4 - verified Issues that have been released and confirmed resolved. and removed 3 - installed Issues that have been merged to master branch and are ready for final confirmation. labels Jan 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@geospatialem geospatialem

@DitwanP DitwanP

Labels
4 - verified Issues that have been released and confirmed resolved. ArcGIS Field Apps Issues logged by ArcGIS Field Apps team members. bug Bug reports for broken functionality. Issues should include a reproduction of the bug. calcite-components Issues specific to the @esri/calcite-components package. estimate - 3 A day or two of work, likely requires updates to tests. impact - p3 - not time sensitive User set priority impact status of p3 - not time sensitive p - medium Issue is non core or affecting less that 60% of people using the library
Projects
None yet
Milestone
2024-01-17 - Jan Main Release
Development

No branches or pull requests
4 participants
@nwhittaker @driskull @geospatialem @DitwanP