Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enhancement: Make selected List item whitespace consistent #7725

Closed
2 of 3 tasks
maxpatiiuk opened this issue Sep 11, 2023 · 1 comment
Closed
2 of 3 tasks

Enhancement: Make selected List item whitespace consistent #7725

maxpatiiuk opened this issue Sep 11, 2023 · 1 comment
Labels
0 - new New issues that need assignment. ArcGIS Maps SDK for JavaScript Issues logged by ArcGIS SDK for JavaScript team members. calcite-components Issues specific to the @esri/calcite-components package. enhancement Issues tied to a new feature or request. impact - p3 - not time sensitive User set priority impact status of p3 - not time sensitive needs triage Planning workflow - pending design/dev review.

Comments

@maxpatiiuk
Copy link
Member

Check existing issues

Description

When rendering List with selectionAppearance="icon", there is too much whitespace between the icon and the label:

MicrosoftTeams-image

Acceptance Criteria

Reduce the whitespace (potentially whitespace to the right of the icon should match that to the left)

Relevant Info

See how much more compact our pre-calcite design has been:

MicrosoftTeams-image (1)

(demo link)

Related issue: #6700

Which Component

List

Example Use Case

Used in the ScaleRangeSlider JS API Widget

Priority impact

p4 - not time sensitive

Calcite package

  • @esri/calcite-components
  • @esri/calcite-components-react

Esri team

ArcGIS Maps SDK for JavaScript
@maxpatiiuk maxpatiiuk added 0 - new New issues that need assignment. enhancement Issues tied to a new feature or request. needs triage Planning workflow - pending design/dev review. labels Sep 11, 2023
@github-actions github-actions bot added ArcGIS Maps SDK for JavaScript Issues logged by ArcGIS SDK for JavaScript team members. impact - p3 - not time sensitive User set priority impact status of p3 - not time sensitive calcite-components Issues specific to the @esri/calcite-components package. labels Sep 11, 2023
@geospatialem
Copy link
Member

This effort will be handled in #7100, targeted for December.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
0 - new New issues that need assignment. ArcGIS Maps SDK for JavaScript Issues logged by ArcGIS SDK for JavaScript team members. calcite-components Issues specific to the @esri/calcite-components package. enhancement Issues tied to a new feature or request. impact - p3 - not time sensitive User set priority impact status of p3 - not time sensitive needs triage Planning workflow - pending design/dev review.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@geospatialem @maxpatiiuk