Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove any logic where disabled affects state across components #7547

Closed
6 of 7 tasks
Elijbet opened this issue Aug 17, 2023 · 3 comments
Closed
6 of 7 tasks

Remove any logic where disabled affects state across components #7547

Elijbet opened this issue Aug 17, 2023 · 3 comments
Assignees
@geospatialem @DitwanP
Labels
4 - verified Issues that have been released and confirmed resolved. breaking change Issues and pull requests with code changes that are not backwards compatible. estimate - 2 Small fix or update, may require updates to tests. p - low Issue is non core or affecting less that 10% of people using the library refactor Issues tied to code that needs to be significantly reworked.
Milestone
2024-11-26 - 3.0....

Comments

@Elijbet
Copy link
Contributor

Elijbet commented Aug 17, 2023 •
edited by jcfranco
Loading

Description

Remove any logic where disabled affects state such as open across all relevant components.

Several components set the open prop to false in the open watcher in a similar fashion:

@Watch("open")
  openHandler(): void {
    // emit events

    if (this.disabled) {
      this.open = false;
      return;
    }

    // do something
  }

Proposed Advantages

It’s a good practice to separate concerns and maintain clear distinctions between different states and behaviors across components.

Which Component

  • combobox (open)
  • dropdown (open)
  • input-date-picker (open)
  • input-time-picker (open)
  • split-button (active – internal prop)

Relevant Info

No response

Calcite package

  • @esri/calcite-components
  • @esri/calcite-components-react
@Elijbet Elijbet added refactor Issues tied to code that needs to be significantly reworked. 0 - new New issues that need assignment. needs triage Planning workflow - pending design/dev review. labels Aug 17, 2023
@Elijbet Elijbet self-assigned this Aug 17, 2023
@Elijbet Elijbet added the estimate - 1 Very small fix or change (potentially a single line), doesn't require updates to tests. label Aug 17, 2023
@geospatialem geospatialem added spike Issues that need quick investigations for time estimations, prioritization, or a quick assessment. p - low Issue is non core or affecting less that 10% of people using the library labels May 28, 2024
@geospatialem geospatialem added 1 - assigned Issues that are assigned to a sprint and a team member. and removed 0 - new New issues that need assignment. labels May 28, 2024
@geospatialem
Copy link
Member

Spike in June to consider for the upcoming breaking change release and determine next steps if a breaking change is needed.

@geospatialem geospatialem removed the needs triage Planning workflow - pending design/dev review. label May 28, 2024
@jcfranco jcfranco added the breaking change Issues and pull requests with code changes that are not backwards compatible. label May 28, 2024
@geospatialem geospatialem removed the spike Issues that need quick investigations for time estimations, prioritization, or a quick assessment. label Aug 12, 2024
@geospatialem geospatialem added estimate - 2 Small fix or update, may require updates to tests. and removed estimate - 1 Very small fix or change (potentially a single line), doesn't require updates to tests. labels Aug 12, 2024
@geospatialem geospatialem added 0 - new New issues that need assignment. and removed 1 - assigned Issues that are assigned to a sprint and a team member. labels Nov 18, 2024
@jcfranco jcfranco self-assigned this Nov 19, 2024
@jcfranco jcfranco added 2 - in development Issues that are actively being worked on. and removed 0 - new New issues that need assignment. labels Nov 19, 2024
@jcfranco jcfranco mentioned this issue Nov 19, 2024
Merged
jcfranco added a commit that referenced this issue Nov 20, 2024
@jcfranco
refactor(combobox, dropdown, input-date-picker, input-time-picker, sp…
a62d704 
…lit-button)!: avoid modifying `open` based on `disabled` prop (#10793)

**Related Issue:** #7547 

## Summary

Updates components to no longer close a component when disabled.

BREAKING CHANGE: Components will no longer close automatically when
disabled. Developers relying on this behavior will also need to update
the `open` property as well.
@jcfranco jcfranco added 3 - installed Issues that have been merged to master branch and are ready for final confirmation. and removed 2 - in development Issues that are actively being worked on. labels Nov 20, 2024
@github-actions github-actions bot assigned geospatialem and DitwanP and unassigned jcfranco Nov 20, 2024
@github-actions GitHub Actions
Copy link
Contributor

Installed and assigned for verification.

@DitwanP
Copy link
Contributor

DitwanP commented Nov 20, 2024

🍡 Verified on 3.0.0-next.17

@DitwanP DitwanP closed this as completed Nov 20, 2024
@DitwanP DitwanP added 4 - verified Issues that have been released and confirmed resolved. and removed 3 - installed Issues that have been merged to master branch and are ready for final confirmation. labels Nov 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@geospatialem geospatialem

@DitwanP DitwanP

Labels
4 - verified Issues that have been released and confirmed resolved. breaking change Issues and pull requests with code changes that are not backwards compatible. estimate - 2 Small fix or update, may require updates to tests. p - low Issue is non core or affecting less that 10% of people using the library refactor Issues tied to code that needs to be significantly reworked.
Projects
None yet
Milestone
2024-11-26 - 3.0.0 Nov Breaking Chang...
Development

No branches or pull requests
4 participants
@jcfranco @geospatialem @Elijbet @DitwanP