Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Chip] Add opt-in affordance for closing closable chip with keyboard. #6825

Open
macandcheese opened this issue Apr 21, 2023 · 0 comments
Open

[Chip] Add opt-in affordance for closing closable chip with keyboard. #6825

macandcheese opened this issue Apr 21, 2023 · 0 comments
Assignees
@jcfranco
Labels
2 - in development Issues that are actively being worked on. Calcite (design) Issues logged by Calcite designers. enhancement Issues tied to a new feature or request. estimate - 5 A few days of work, definitely requires updates to tests. impact - p3 - not time sensitive User set priority impact status of p3 - not time sensitive p - low Issue is non core or affecting less that 10% of people using the library
Milestone
2024-11-26 - 3.0....

Comments

@macandcheese
Copy link
Contributor

Description

As suggested in Chip Group PR, consider having an additional and opt-in (or opt-out?) functionality to allow users to use a key (probably delete) to close a closable chip while focused on the chip. Currently a user must navigate to the close button to take this action via keyboard.

Acceptance Criteria

Chip has a new property - allow/disallow-close-via-key (with a better name) to enable the described functionality.

Relevant Info

No response

Which Component

Chip cc @jcfranco

Example Use Case

No response

Priority impact

p4 - not time sensitive

Esri team

Calcite (design)
@macandcheese macandcheese added enhancement Issues tied to a new feature or request. 0 - new New issues that need assignment. needs triage Planning workflow - pending design/dev review. labels Apr 21, 2023
@github-actions github-actions bot added impact - p3 - not time sensitive User set priority impact status of p3 - not time sensitive Calcite (design) Issues logged by Calcite designers. labels Apr 21, 2023
@geospatialem geospatialem mentioned this issue Apr 21, 2023
Closed
@geospatialem geospatialem added p - low Issue is non core or affecting less that 10% of people using the library estimate - 5 A few days of work, definitely requires updates to tests. needs milestone Planning workflow - pending milestone assignment, has priority and/or estimate. and removed needs triage Planning workflow - pending design/dev review. labels Apr 2, 2024
@geospatialem geospatialem added this to the 2024-11-19 - Nov Release milestone Apr 3, 2024
@geospatialem geospatialem removed the needs milestone Planning workflow - pending milestone assignment, has priority and/or estimate. label Apr 3, 2024
@jcfranco jcfranco self-assigned this Nov 23, 2024
@jcfranco jcfranco added 2 - in development Issues that are actively being worked on. and removed 0 - new New issues that need assignment. labels Nov 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jcfranco jcfranco

Labels
2 - in development Issues that are actively being worked on. Calcite (design) Issues logged by Calcite designers. enhancement Issues tied to a new feature or request. estimate - 5 A few days of work, definitely requires updates to tests. impact - p3 - not time sensitive User set priority impact status of p3 - not time sensitive p - low Issue is non core or affecting less that 10% of people using the library
Projects
None yet
Milestone
2024-11-26 - 3.0.0 Nov Breaking Chang...
Development

No branches or pull requests
3 participants
@jcfranco @macandcheese @geospatialem