Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Discussion on API consistency refactor for expand/collapse props #6032

Closed
geospatialem opened this issue Dec 14, 2022 · 1 comment
Closed

Discussion on API consistency refactor for expand/collapse props #6032

geospatialem opened this issue Dec 14, 2022 · 1 comment
Labels
0 - new New issues that need assignment. discussion Issues relating to a conversation where feedback is optional. needs triage Planning workflow - pending design/dev review. refactor Issues tied to code that needs to be significantly reworked.

Comments

@geospatialem
Copy link
Member

geospatialem commented Dec 14, 2022 •
edited
Loading

Description

To discuss refactored API consistency for expand*/collapse* props.

Some examples include:

  • expanded
  • expandDisabled
  • collapsed

Proposed Advantages

Consistent props across components.

Which Component

Any component that matches audit findings.

Relevant Info

Stems from 4688's discussion.
@geospatialem geospatialem added discussion Issues relating to a conversation where feedback is optional. refactor Issues tied to code that needs to be significantly reworked. 0 - new New issues that need assignment. needs triage Planning workflow - pending design/dev review. labels Dec 14, 2022
@geospatialem
Copy link
Member Author

Closing in favor of #6473

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
0 - new New issues that need assignment. discussion Issues relating to a conversation where feedback is optional. needs triage Planning workflow - pending design/dev review. refactor Issues tied to code that needs to be significantly reworked.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@alisonailea @geospatialem