-
Notifications
You must be signed in to change notification settings - Fork 76
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Chip: Rename color
property to kind
and rename values
#5953
Comments
A note, these will again change when the chip-group / chip proposed updates are added. The values for We should in the meantime remove the |
Installed and assigned for verification. |
In the future, we can create one issue for doing the same task, even if it is split across multiple components (e.g. renaming a property or two). We can still do separate PRs per component, but having one issue makes it easier to track and manage. For example #5798 and #2925 We could say "rename |
SO much easier. Thanks, @benelan for the clarification. This is Aaron and my preference as well 😂 |
Installed and assigned for verification. |
Was able to verify the
Codepen for verification for |
Description
To improve clarity and consistency across the system, the
color
property should be renamed tokind
. The values should also be renamed to align with this scheme and abrand
version added.Acceptance Criteria
kind
=brand | danger | info | neutral | success | warning
Brand variant added.
Relevant Info
No response
Which Component
Chip
Example Use Case
No response
Esri team
Calcite (design)
The text was updated successfully, but these errors were encountered: