Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Chip: Rename color property to kind and rename values #5953

Closed
ashetland opened this issue Dec 8, 2022 · 9 comments
Closed

Chip: Rename color property to kind and rename values #5953

ashetland opened this issue Dec 8, 2022 · 9 comments
Assignees
Labels
4 - verified Issues that have been released and confirmed resolved. breaking change Issues and pull requests with code changes that are not backwards compatible. Calcite (design) Issues logged by Calcite designers. enhancement Issues tied to a new feature or request.

Comments

@ashetland
Copy link

Description

To improve clarity and consistency across the system, the color property should be renamed to kind. The values should also be renamed to align with this scheme and a brand version added.

CleanShot 2022-12-08 at 11 32 37@2x

Acceptance Criteria

kind = brand | danger | info | neutral | success | warning

Brand variant added.

Relevant Info

No response

Which Component

Chip

Example Use Case

No response

Esri team

Calcite (design)

@ashetland ashetland added enhancement Issues tied to a new feature or request. breaking change Issues and pull requests with code changes that are not backwards compatible. 0 - new New issues that need assignment. needs triage Planning workflow - pending design/dev review. labels Dec 8, 2022
@ashetland
Copy link
Author

cc @SkyeSeitz @geospatialem @macandcheese

@github-actions github-actions bot added the Calcite (design) Issues logged by Calcite designers. label Dec 8, 2022
@geospatialem geospatialem removed the needs triage Planning workflow - pending design/dev review. label Dec 8, 2022
@geospatialem geospatialem added this to the 2023 January Priorities milestone Dec 8, 2022
@macandcheese
Copy link
Contributor

A note, these will again change when the chip-group / chip proposed updates are added. The values for kind at that time will be brand, neutral, and inverse. The appearance values will match that of button.

We should in the meantime remove the transparent appearance type, that was never intended to be used for Chip.

@macandcheese macandcheese self-assigned this Dec 14, 2022
@ashetland
Copy link
Author

ashetland commented Dec 14, 2022

Overview sticker sheet.

kind proposal

@macandcheese macandcheese added 1 - assigned Issues that are assigned to a sprint and a team member. 2 - in development Issues that are actively being worked on. 3 - installed Issues that have been merged to master branch and are ready for final confirmation. and removed 0 - new New issues that need assignment. 1 - assigned Issues that are assigned to a sprint and a team member. 2 - in development Issues that are actively being worked on. labels Dec 15, 2022
@github-actions
Copy link
Contributor

Installed and assigned for verification.

@macandcheese macandcheese added 2 - in development Issues that are actively being worked on. and removed 3 - installed Issues that have been merged to master branch and are ready for final confirmation. labels Dec 15, 2022
@ashetland
Copy link
Author

Updated sticker sheets that include the new updates to Chip. Accordion was removed from these as those updates will happen post-v1.0.

updated kind proposal

@benelan
Copy link
Member

benelan commented Dec 15, 2022

In the future, we can create one issue for doing the same task, even if it is split across multiple components (e.g. renaming a property or two). We can still do separate PRs per component, but having one issue makes it easier to track and manage. For example #5798 and #2925

We could say "rename color and outline on components x, y, z"

@SkyeSeitz
Copy link

In the future, we can create one issue for doing the same task, even if it is split across multiple components (e.g. renaming a property or two). We can still do separate PRs per component, but having one issue makes it easier to track and manage. For example #5798 and #2925

We could say "rename color and outline on components x, y, z"

SO much easier. Thanks, @benelan for the clarification. This is Aaron and my preference as well 😂

@macandcheese macandcheese added 3 - installed Issues that have been merged to master branch and are ready for final confirmation. and removed 2 - in development Issues that are actively being worked on. labels Dec 15, 2022
@github-actions
Copy link
Contributor

Installed and assigned for verification.

@geospatialem
Copy link
Member

geospatialem commented Dec 16, 2022

Was able to verify the kind values for "brand", "neutral" and "inverse".

Do we need to verify for the remaining values? cc @ashetland @SkyeSeitz
Nevermind, the brilliant Adam mentioned the last sticker was updated. This is verified

Codepen for verification for "danger", "info", "success", and "warning"?

image

@geospatialem geospatialem added 4 - verified Issues that have been released and confirmed resolved. and removed 3 - installed Issues that have been merged to master branch and are ready for final confirmation. labels Jan 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
4 - verified Issues that have been released and confirmed resolved. breaking change Issues and pull requests with code changes that are not backwards compatible. Calcite (design) Issues logged by Calcite designers. enhancement Issues tied to a new feature or request.
Projects
None yet
Development

No branches or pull requests

5 participants