Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Radio Button keyboard navigation doesn't work as expected when a group contains disabled options #10844

Open
2 of 6 tasks
eriklharper opened this issue Nov 22, 2024 · 0 comments
Labels
0 - new New issues that need assignment. bug Bug reports for broken functionality. Issues should include a reproduction of the bug. c-radio-button Issue related to calcite-radio-button Calcite (dev) Issues logged by Calcite developers. calcite-components Issues specific to the @esri/calcite-components package. impact - p1 - need for current milestone User set priority impact status of p1 - need for current milestone needs triage Planning workflow - pending design/dev review.

Comments

@eriklharper
Copy link
Contributor

Check existing issues

Actual Behavior

When using calcite-radio-buttons in a grouping with some disabled options, unexpected behavior occurs:

  • Round robin selection fails to work (moves between the first and last items when the appropriate key is pressed).
  • Disabled options are not skipped over when navigating with the keyboard.

All of these bugs happen with or without a parent calcite-radio-button-group.

Expected Behavior

Within a group of radios that share the same name and also include some disabled options:

  • "Round robin" keyboard selection should still work where pressing ArrowLeft on the first option selects the last non-disabled option and vice versa.
  • When navigating around the group, the disabled one should always be skipped so that the next selectable option is able to be selected with the keyboard.

Reproduction Sample

https://codepen.io/eriklharper/pen/dyxxPQa?editors=1010

Reproduction Steps

See codepen for instructions.

Reproduction Version

v2

Relevant Info

No response

Regression?

Yes, unknown

Priority impact

impact - p1 - need for current milestone

Impact

This affects keyboard user accessibility.

Calcite package

  • @esri/calcite-components
  • @esri/calcite-components-react
  • @esri/calcite-design-tokens
  • @esri/calcite-ui-icons
  • @esri/eslint-plugin-calcite-components

Esri team

Calcite (dev)

@eriklharper eriklharper added bug Bug reports for broken functionality. Issues should include a reproduction of the bug. 0 - new New issues that need assignment. needs triage Planning workflow - pending design/dev review. c-radio-button Issue related to calcite-radio-button labels Nov 22, 2024
@github-actions github-actions bot added Calcite (dev) Issues logged by Calcite developers. calcite-components Issues specific to the @esri/calcite-components package. impact - p1 - need for current milestone User set priority impact status of p1 - need for current milestone labels Nov 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
0 - new New issues that need assignment. bug Bug reports for broken functionality. Issues should include a reproduction of the bug. c-radio-button Issue related to calcite-radio-button Calcite (dev) Issues logged by Calcite developers. calcite-components Issues specific to the @esri/calcite-components package. impact - p1 - need for current milestone User set priority impact status of p1 - need for current milestone needs triage Planning workflow - pending design/dev review.
Projects
None yet
Development

No branches or pull requests

1 participant