Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Default transitions not wired properly #10837

Closed
2 of 6 tasks
jcfranco opened this issue Nov 22, 2024 · 2 comments
Closed
2 of 6 tasks

Default transitions not wired properly #10837

jcfranco opened this issue Nov 22, 2024 · 2 comments
Assignees
@geospatialem @DitwanP
Labels
4 - verified Issues that have been released and confirmed resolved. bug Bug reports for broken functionality. Issues should include a reproduction of the bug. Calcite (dev) Issues logged by Calcite developers. calcite-components Issues specific to the @esri/calcite-components package. estimate - 1 Very small fix or change (potentially a single line), doesn't require updates to tests. impact - p3 - not time sensitive User set priority impact status of p3 - not time sensitive p - medium Issue is non core or affecting less that 60% of people using the library
Milestone
2024-11-26 - 3.0....

Comments

@jcfranco
Copy link
Member

Check existing issues

Actual Behavior

#8797 unintentionally removed the transition duration on all default props.

Expected Behavior

Default transitions should honor the --calcite-duration-factor.

Reproduction Sample

https://codepen.io/jcfranco/pen/XWvvXEz?editors=100

Reproduction Steps

Hover over the checkbox and notice the check border immediately change color.

Reproduction Version

2.13.2

Relevant Info

No response

Regression?

2.7.0

Priority impact

impact - p3 - not time sensitive

Impact

No response

Calcite package

  • @esri/calcite-components
  • @esri/calcite-components-react
  • @esri/calcite-design-tokens
  • @esri/calcite-ui-icons
  • @esri/eslint-plugin-calcite-components

Esri team

Calcite (dev)
@jcfranco jcfranco added bug Bug reports for broken functionality. Issues should include a reproduction of the bug. 0 - new New issues that need assignment. needs triage Planning workflow - pending design/dev review. labels Nov 22, 2024
@github-actions github-actions bot added Calcite (dev) Issues logged by Calcite developers. calcite-components Issues specific to the @esri/calcite-components package. impact - p3 - not time sensitive User set priority impact status of p3 - not time sensitive labels Nov 22, 2024
@jcfranco jcfranco mentioned this issue Nov 22, 2024
Merged
jcfranco added a commit that referenced this issue Nov 22, 2024
@jcfranco
fix: fix core transitions across components (#10836)
47fe92d 
**Related Issue:** #10837

## Summary

Splits up props set by the `transition-default` Tailwind util, so they
are all configured correctly.

This came up in
#10835. It turns out
#10835 wasn't set up
properly and core transitions were not working.

**Note**: Removed `outline` and `outline-offset` as these were
configured with defaults and are not animated by default.
@jcfranco jcfranco added 2 - in development Issues that are actively being worked on. estimate - 1 Very small fix or change (potentially a single line), doesn't require updates to tests. p - medium Issue is non core or affecting less that 60% of people using the library and removed 0 - new New issues that need assignment. needs triage Planning workflow - pending design/dev review. labels Nov 22, 2024
@jcfranco jcfranco self-assigned this Nov 22, 2024
@jcfranco jcfranco added the 3 - installed Issues that have been merged to master branch and are ready for final confirmation. label Nov 22, 2024
@github-actions github-actions bot removed the 2 - in development Issues that are actively being worked on. label Nov 22, 2024
@github-actions github-actions bot assigned geospatialem and DitwanP and unassigned jcfranco Nov 22, 2024
@github-actions GitHub Actions
Copy link
Contributor

Installed and assigned for verification.

@DitwanP
Copy link
Contributor

DitwanP commented Nov 22, 2024

Verified locally on dev

@DitwanP DitwanP closed this as completed Nov 22, 2024
@DitwanP DitwanP added 4 - verified Issues that have been released and confirmed resolved. and removed 3 - installed Issues that have been merged to master branch and are ready for final confirmation. labels Nov 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@geospatialem geospatialem

@DitwanP DitwanP

Labels
4 - verified Issues that have been released and confirmed resolved. bug Bug reports for broken functionality. Issues should include a reproduction of the bug. Calcite (dev) Issues logged by Calcite developers. calcite-components Issues specific to the @esri/calcite-components package. estimate - 1 Very small fix or change (potentially a single line), doesn't require updates to tests. impact - p3 - not time sensitive User set priority impact status of p3 - not time sensitive p - medium Issue is non core or affecting less that 60% of people using the library
Projects
None yet
Milestone
2024-11-26 - 3.0.0 Nov Breaking Chang...
Development

No branches or pull requests
3 participants
@jcfranco @geospatialem @DitwanP