Run internal samples with skipLibCheck: false?

[maxpatiiuk]

Priority impact

p - low

Test type

Integration

Which Component(s)

all

Unstable Tests

No response

Test error, if applicable

Calcite's samples at the moment appear to set the skipLibCheck: true option:

https://github.com/Esri/calcite-design-system/blob/main/examples/components/react/tsconfig.app.json#L7

This option disables type-checking of Calcite's output .d.ts files. While the option is commonly recommended, it is not on by default in TypeScript, not on by default in many starter templates out there, and can not be enabled in some projects (like JS API).

Thus, it might be advisable for Calcite's internal samples testing to also have this option disabled, to opt into additional checks.

This check will detect issues like the following earlier in the future, before they affect consumers:

• fix(t9n): make TypeScript inline .json type imports #10804
• fix(flow-item): fix TS error caused by FlowItemLike type #10802
• build: ensure types are specified in TS files #10800
• Issue 2016 in AWC repository

PR skipped, if applicable

No response

Additional Info

No response