Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Shell Panel] Improve support for adjusting height of float-all display mode #10825

Open
2 of 5 tasks
macandcheese opened this issue Nov 21, 2024 · 1 comment
Open
2 of 5 tasks

[Shell Panel] Improve support for adjusting height of float-all display mode #10825

macandcheese opened this issue Nov 21, 2024 · 1 comment
Labels
0 - new New issues that need assignment. ArcGIS Data Pipelines Issues logged by ArcGIS Data Pipelines team members. Calcite (design) Issues logged by Calcite designers. calcite-components Issues specific to the @esri/calcite-components package. enhancement Issues tied to a new feature or request. impact - p3 - not time sensitive User set priority impact status of p3 - not time sensitive needs triage Planning workflow - pending design/dev review.

Comments

@macandcheese
Copy link
Contributor

Check existing issues

Description

Given a Shell Panel in layout="vertical" and display-mode="float-all" configuration, a user cannot adjust the height of the component using either the heightScale property or css properties.

Acceptance Criteria

I'd expect any height settings take effect across all display modes and layouts. This may necessitate the addition of a "full" value for a value - not sure if that is needed or if certain modes can just use overridable defaults.

Relevant Info

No response

Which Component

Shell Panel

Example Use Case

No response

Priority impact

impact - p3 - not time sensitive

Calcite package

  • @esri/calcite-components
  • @esri/calcite-components-react
  • @esri/calcite-design-tokens
  • @esri/eslint-plugin-calcite-components

Esri team

Calcite (design)
@macandcheese macandcheese added enhancement Issues tied to a new feature or request. 0 - new New issues that need assignment. needs triage Planning workflow - pending design/dev review. labels Nov 21, 2024
@github-actions github-actions bot added Calcite (design) Issues logged by Calcite designers. calcite-components Issues specific to the @esri/calcite-components package. impact - p3 - not time sensitive User set priority impact status of p3 - not time sensitive labels Nov 21, 2024
@doreenbrinkman
Copy link

doreenbrinkman commented Nov 21, 2024 •
edited
Loading

+1 Needed for ArcGIS Data Pipelines to migrate from deprecated calcite-shell-center-row and implement expanding and collapsing based on height, with layout horizontal and displayMode float-all. We will stay with calcite-shell-center-row until deprecated in 4.0.

@macandcheese macandcheese added the ArcGIS Data Pipelines Issues logged by ArcGIS Data Pipelines team members. label Nov 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
0 - new New issues that need assignment. ArcGIS Data Pipelines Issues logged by ArcGIS Data Pipelines team members. Calcite (design) Issues logged by Calcite designers. calcite-components Issues specific to the @esri/calcite-components package. enhancement Issues tied to a new feature or request. impact - p3 - not time sensitive User set priority impact status of p3 - not time sensitive needs triage Planning workflow - pending design/dev review.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@macandcheese @doreenbrinkman