Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Dropdown / Dropdown Item] decrease height for 4.0 #10782

Open
2 of 8 tasks
geospatialem opened this issue Nov 18, 2024 · 0 comments
Open
2 of 8 tasks

[Dropdown / Dropdown Item] decrease height for 4.0 #10782

geospatialem opened this issue Nov 18, 2024 · 0 comments
Labels
0 - new New issues that need assignment. Calcite (design) Issues logged by Calcite designers. calcite-components Issues specific to the @esri/calcite-components package. design Issues that need design consultation prior to development. enhancement Issues tied to a new feature or request. estimate - 2 Small fix or update, may require updates to tests. impact - p3 - not time sensitive User set priority impact status of p3 - not time sensitive p - high Issue should be addressed in the current milestone, impacts component or core functionality visual changes Issues with visual changes that are added for consistency, but are not backwards compatible

Comments

@geospatialem
Copy link
Member

geospatialem commented Nov 18, 2024

Draft proposal - pending user feedback

Check existing issues

Description

Reduce the dropdown-item height to match the scale of other components.

Blocked issues: #10783

Acceptance Criteria

  • small = 24px
  • medium = 32px
  • large = no change

Relevant Info

Part of 4.0's Phase III

Which Component

  • dropdown
  • dropdown-item

Example Use Case

No response

Priority impact

impact - p3 - not time sensitive

Calcite package

  • @esri/calcite-components
  • @esri/calcite-components-react
  • @esri/calcite-design-tokens
  • @esri/eslint-plugin-calcite-components

Esri team

Calcite (design)

@geospatialem geospatialem added enhancement Issues tied to a new feature or request. design Issues that need design consultation prior to development. p - high Issue should be addressed in the current milestone, impacts component or core functionality 0 - new New issues that need assignment. estimate - 2 Small fix or update, may require updates to tests. visual changes Issues with visual changes that are added for consistency, but are not backwards compatible labels Nov 18, 2024
@github-actions github-actions bot added Calcite (design) Issues logged by Calcite designers. calcite-components Issues specific to the @esri/calcite-components package. impact - p3 - not time sensitive User set priority impact status of p3 - not time sensitive labels Nov 18, 2024
@ashetland ashetland changed the title [Dropdown / Dropdown Item] Update selection appearances and decrease height for 4.0 [Dropdown / Dropdown Item] decrease height for 4.0 Nov 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
0 - new New issues that need assignment. Calcite (design) Issues logged by Calcite designers. calcite-components Issues specific to the @esri/calcite-components package. design Issues that need design consultation prior to development. enhancement Issues tied to a new feature or request. estimate - 2 Small fix or update, may require updates to tests. impact - p3 - not time sensitive User set priority impact status of p3 - not time sensitive p - high Issue should be addressed in the current milestone, impacts component or core functionality visual changes Issues with visual changes that are added for consistency, but are not backwards compatible
Projects
None yet
Development

No branches or pull requests

1 participant