Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Action slots] update sizing and spacing for slotted actions for 4.0 (Feb) #10777

Open
2 of 27 tasks
DitwanP opened this issue Nov 18, 2024 · 0 comments
Open
2 of 27 tasks

[Action slots] update sizing and spacing for slotted actions for 4.0 (Feb) #10777

DitwanP opened this issue Nov 18, 2024 · 0 comments
Labels
0 - new New issues that need assignment. blocked This issue is blocked by another issue. Calcite (design) Issues logged by Calcite designers. calcite-components Issues specific to the @esri/calcite-components package. enhancement Issues tied to a new feature or request. estimate - 5 A few days of work, definitely requires updates to tests. impact - p3 - not time sensitive User set priority impact status of p3 - not time sensitive p - high Issue should be addressed in the current milestone, impacts component or core functionality visual changes Issues with visual changes that are added for consistency, but are not backwards compatible

Comments

@DitwanP
Copy link
Contributor

DitwanP commented Nov 18, 2024 •
edited by ashetland
Loading

Draft proposal - pending user feedback

Check existing issues

Description

Update the styling of slotted action components

Acceptance Criteria

Make the following changes for the the components and slots listed below.

  • Update all slots to hug height instead of flexing to fill
  • Add gap
  • Add padding/margin

  1. Accordion Item

    • actions-start
    • actions-end

  2. Action Bar

    • actions-end

  3. Action Group

    • menu-actions

  4. Alert

    • actions-end

  5. Block

    • actions-end
    • header-menu-actions

  6. Dialog, Panel, and Flow

    • header-actions-start
    • header-actions-end
    • header-menu-actions

  7. Input, Input Number, Input Text

    • action

  8. List

    • filter-actions-start
    • filter-actions-end

  9. List Item

    • actions-start
    • actions-end

  10. Navigation

    • navigation-action

  11. Notice

    • actions-end

  12. Table

    • selection-actions

  13. Tree Item

    • actions-end

  14. Pick List, Value List (should be removed in 3.0)

Relevant Info

Part of 4.0's Phase 2

Blocked by: #10759

Which Component

  • accordion-item
  • action-bar
  • action-group
  • alert
  • block
  • dialog, panel, flow
  • input, input-number, input-text
  • list
  • list-item
  • navigation
  • notice
  • table
  • tree-item

Example Use Case

No response

Priority impact

impact - p3 - not time sensitive

Calcite package

  • @esri/calcite-components
  • @esri/calcite-components-react
  • @esri/calcite-design-tokens
  • @esri/eslint-plugin-calcite-components

Esri team

Calcite (design)
@DitwanP DitwanP added enhancement Issues tied to a new feature or request. p - high Issue should be addressed in the current milestone, impacts component or core functionality 0 - new New issues that need assignment. blocked This issue is blocked by another issue. estimate - 5 A few days of work, definitely requires updates to tests. visual changes Issues with visual changes that are added for consistency, but are not backwards compatible labels Nov 18, 2024
@github-actions github-actions bot added Calcite (design) Issues logged by Calcite designers. calcite-components Issues specific to the @esri/calcite-components package. impact - p3 - not time sensitive User set priority impact status of p3 - not time sensitive labels Nov 18, 2024
@DitwanP DitwanP mentioned this issue Nov 18, 2024
Open
18 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
0 - new New issues that need assignment. blocked This issue is blocked by another issue. Calcite (design) Issues logged by Calcite designers. calcite-components Issues specific to the @esri/calcite-components package. enhancement Issues tied to a new feature or request. estimate - 5 A few days of work, definitely requires updates to tests. impact - p3 - not time sensitive User set priority impact status of p3 - not time sensitive p - high Issue should be addressed in the current milestone, impacts component or core functionality visual changes Issues with visual changes that are added for consistency, but are not backwards compatible
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@DitwanP