Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Tree / Tree Item] Consistent selection enhancements for 4.0 #10776

Open
2 of 9 tasks
geospatialem opened this issue Nov 18, 2024 · 0 comments
Open
2 of 9 tasks

[Tree / Tree Item] Consistent selection enhancements for 4.0 #10776

geospatialem opened this issue Nov 18, 2024 · 0 comments
Labels
0 - new New issues that need assignment. Calcite (design) Issues logged by Calcite designers. calcite-components Issues specific to the @esri/calcite-components package. design Issues that need design consultation prior to development. enhancement Issues tied to a new feature or request. estimate - 5 A few days of work, definitely requires updates to tests. impact - p3 - not time sensitive User set priority impact status of p3 - not time sensitive p - high Issue should be addressed in the current milestone, impacts component or core functionality visual changes Issues with visual changes that are added for consistency, but are not backwards compatible
Milestone
2025-11-18 - 4.0....

Comments

@geospatialem
Copy link
Member

geospatialem commented Nov 18, 2024 •
edited by ashetland
Loading

Draft proposal - pending user feedback

Check existing issues

Description

Update the component's selection appearance.

Acceptance Criteria

  • Add a new selectionAppearance prop with "icon" (default) and "highlight" values
  • Update the text color to text.1
  • Update the single select icon to the thicker checkmark (refer to the relevant info below regarding the new icon request)
  • Remove font weight change on selection

Relevant Info

A new icon for a thicker checkmark is needed prior to this effort, which has been logged internally.

Part of 4.0's Phase III - Selection

Which Component

  • tree
  • tree-item

Example Use Case

No response

Priority impact

impact - p3 - not time sensitive

Calcite package

  • @esri/calcite-components
  • @esri/calcite-components-react
  • @esri/calcite-design-tokens
  • @esri/eslint-plugin-calcite-components

Esri team

Calcite (design)
@geospatialem geospatialem added enhancement Issues tied to a new feature or request. design Issues that need design consultation prior to development. p - high Issue should be addressed in the current milestone, impacts component or core functionality 0 - new New issues that need assignment. estimate - 5 A few days of work, definitely requires updates to tests. labels Nov 18, 2024
@github-actions github-actions bot added Calcite (design) Issues logged by Calcite designers. calcite-components Issues specific to the @esri/calcite-components package. impact - p3 - not time sensitive User set priority impact status of p3 - not time sensitive labels Nov 18, 2024
@geospatialem geospatialem added the visual changes Issues with visual changes that are added for consistency, but are not backwards compatible label Nov 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
0 - new New issues that need assignment. Calcite (design) Issues logged by Calcite designers. calcite-components Issues specific to the @esri/calcite-components package. design Issues that need design consultation prior to development. enhancement Issues tied to a new feature or request. estimate - 5 A few days of work, definitely requires updates to tests. impact - p3 - not time sensitive User set priority impact status of p3 - not time sensitive p - high Issue should be addressed in the current milestone, impacts component or core functionality visual changes Issues with visual changes that are added for consistency, but are not backwards compatible
Projects
None yet
Milestone
2025-11-18 - 4.0.0 Nov Breaking Chang...
Development

No branches or pull requests
1 participant
@geospatialem