Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Token] Update border colors for 4.0 #10755

Open
3 of 5 tasks
geospatialem opened this issue Nov 18, 2024 · 0 comments
Open
3 of 5 tasks

[Token] Update border colors for 4.0 #10755

geospatialem opened this issue Nov 18, 2024 · 0 comments
Labels
0 - new New issues that need assignment. breaking change Issues and pull requests with code changes that are not backwards compatible. Calcite (design) Issues logged by Calcite designers. calcite-components Issues specific to the @esri/calcite-components package. calcite-design-tokens Issues specific to the @esri/calcite-design-tokens package. design Issues that need design consultation prior to development. design-tokens Issues requiring design tokens. enhancement Issues tied to a new feature or request. estimate - 3 A day or two of work, likely requires updates to tests. impact - p3 - not time sensitive User set priority impact status of p3 - not time sensitive p - high Issue should be addressed in the current milestone, impacts component or core functionality visual changes Issues with visual changes that are added for consistency, but are not backwards compatible
Milestone
2025-11-18 - 4.0....

Comments

@geospatialem
Copy link
Member

geospatialem commented Nov 18, 2024 •
edited by ashetland
Loading

Draft proposal - pending user feedback

Check existing issues

Description

Update values of semantic tokens border color tokens.

image

Blocked issues: #10769

Acceptance Criteria

Light

  • border.3 value=“core.neutral.blk.020”
  • border.2 value=“core.neutral.blk.030”
  • border.1 value=“core.neutral.blk.040”

Dark

  • border.3 value=“core.neutral.blk.170”
  • border.2 value=“core.neutral.blk.160”
  • border.1 value=“core.neutral.blk.150”

Relevant Info

🔗 Link to Figma Specs

Part of 4.0's Phase I - Colors

Blocked Issues: #10769

Which Component

Tokens

Example Use Case

Refer to relevant info above.

Priority impact

impact - p3 - not time sensitive

Calcite package

  • @esri/calcite-components
  • @esri/calcite-components-react
  • @esri/calcite-design-tokens
  • @esri/eslint-plugin-calcite-components

Esri team

Calcite (design)
@geospatialem geospatialem added enhancement Issues tied to a new feature or request. design Issues that need design consultation prior to development. breaking change Issues and pull requests with code changes that are not backwards compatible. p - high Issue should be addressed in the current milestone, impacts component or core functionality 0 - new New issues that need assignment. estimate - 3 A day or two of work, likely requires updates to tests. design-tokens Issues requiring design tokens. labels Nov 18, 2024
@github-actions github-actions bot added Calcite (design) Issues logged by Calcite designers. calcite-components Issues specific to the @esri/calcite-components package. calcite-design-tokens Issues specific to the @esri/calcite-design-tokens package. impact - p3 - not time sensitive User set priority impact status of p3 - not time sensitive labels Nov 18, 2024
@DitwanP DitwanP mentioned this issue Nov 18, 2024
Open
7 tasks
@geospatialem geospatialem added the visual changes Issues with visual changes that are added for consistency, but are not backwards compatible label Nov 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
0 - new New issues that need assignment. breaking change Issues and pull requests with code changes that are not backwards compatible. Calcite (design) Issues logged by Calcite designers. calcite-components Issues specific to the @esri/calcite-components package. calcite-design-tokens Issues specific to the @esri/calcite-design-tokens package. design Issues that need design consultation prior to development. design-tokens Issues requiring design tokens. enhancement Issues tied to a new feature or request. estimate - 3 A day or two of work, likely requires updates to tests. impact - p3 - not time sensitive User set priority impact status of p3 - not time sensitive p - high Issue should be addressed in the current milestone, impacts component or core functionality visual changes Issues with visual changes that are added for consistency, but are not backwards compatible
Projects
None yet
Milestone
2025-11-18 - 4.0.0 Nov Breaking Chang...
Development

No branches or pull requests
1 participant
@geospatialem