Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[calcite-checkbox]: Initial render of unselected checkbox does not show up in high contrast #10537

Closed
2 of 6 tasks
jasdelreyes opened this issue Oct 14, 2024 · 4 comments
Closed
2 of 6 tasks

[calcite-checkbox]: Initial render of unselected checkbox does not show up in high contrast #10537

jasdelreyes opened this issue Oct 14, 2024 · 4 comments
Assignees
@geospatialem @DitwanP
Labels
4 - verified Issues that have been released and confirmed resolved. a11y Issues related to Accessibility fixes or improvements. ArcGIS Online Issues logged by ArcGIS Online team members. bug Bug reports for broken functionality. Issues should include a reproduction of the bug. calcite-components Issues specific to the @esri/calcite-components package. estimate - 2 Small fix or update, may require updates to tests. impact - p2 - want for an upcoming milestone User set priority impact status of p2 - want for an upcoming milestone p - high Issue should be addressed in the current milestone, impacts component or core functionality
Milestone
2024-11-26 - 3.0....

Comments

@jasdelreyes
Copy link

jasdelreyes commented Oct 14, 2024 •
edited
Loading

Check existing issues

Summary

Calcite checkbox is not visible on initial render when unselected in high contrast browsers.

More details on repro: https://devtopia.esri.com/WebGIS/arcgis-portal-app/issues/54063

Other relevant issue: https://devtopia.esri.com/WebGIS/arcgis-app-components/issues/5887

Actual Behavior

When calcite checkbox is used in high contrast browsers, the initial render of the component, when unselected, does not show visibly.

Expected Behavior

Calcite checkbox's box outline should always be visible.

Reproduction Sample

https://codepen.io/jasdelreyes/pen/MWNpvKO?editors=100

Reproduction Steps

  1. Turn on high contrast mode in your browser or operating system.
  • This was initially found on a Windows computer on Firefox with high contrast mode on
  1. Visit the codepen link mentioned above

Reproduction Version

~2.13.1

Working W3C Example/Tutorial

No response

Relevant Info

No response

Regression?

No response

Priority impact

impact - p2 - want for an upcoming milestone

Calcite package

  • @esri/calcite-components
  • @esri/calcite-components-angular
  • @esri/calcite-components-react
  • @esri/calcite-design-tokens
  • @esri/eslint-plugin-calcite-components

Esri team

ArcGIS Online
@jasdelreyes jasdelreyes added 0 - new New issues that need assignment. a11y Issues related to Accessibility fixes or improvements. bug Bug reports for broken functionality. Issues should include a reproduction of the bug. needs triage Planning workflow - pending design/dev review. p - high Issue should be addressed in the current milestone, impacts component or core functionality labels Oct 14, 2024
@github-actions github-actions bot added ArcGIS Online Issues logged by ArcGIS Online team members. calcite-components Issues specific to the @esri/calcite-components package. impact - p2 - want for an upcoming milestone User set priority impact status of p2 - want for an upcoming milestone labels Oct 14, 2024
@jasdelreyes
Copy link
Author

cc @paulcpederson @mpriour

@mpriour
Copy link
Member

mpriour commented Oct 14, 2024

Happy to look at this and make a PR to fix it.

@mpriour mpriour mentioned this issue Oct 14, 2024
Closed
@jcfranco jcfranco added 2 - in development Issues that are actively being worked on. and removed needs triage Planning workflow - pending design/dev review. 0 - new New issues that need assignment. labels Oct 18, 2024
@jcfranco jcfranco added this to the 2024-10-29 - Oct Milestone milestone Oct 18, 2024
@jcfranco jcfranco added the estimate - 2 Small fix or update, may require updates to tests. label Oct 18, 2024
@jcfranco jcfranco mentioned this issue Nov 21, 2024
Merged
@jcfranco jcfranco self-assigned this Nov 21, 2024
jcfranco added a commit that referenced this issue Nov 21, 2024
@jcfranco
fix(checkbox): ensure that border shows in high contrast mode (#10823)
ff05231 
**Related Issue:** #10537 

## Summary

Applies a border for high contrast mode in Firefox.
@jcfranco jcfranco added 3 - installed Issues that have been merged to master branch and are ready for final confirmation. and removed 2 - in development Issues that are actively being worked on. labels Nov 21, 2024
@github-actions GitHub Actions
Copy link
Contributor

Installed and assigned for verification.

@DitwanP
Copy link
Contributor

DitwanP commented Nov 21, 2024

🍡 Verified, checkbox is visible on high contrast using 3.0.0-next.20
image

@DitwanP DitwanP closed this as completed Nov 21, 2024
@DitwanP DitwanP added 4 - verified Issues that have been released and confirmed resolved. and removed 3 - installed Issues that have been merged to master branch and are ready for final confirmation. labels Nov 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@geospatialem geospatialem

@DitwanP DitwanP

Labels
4 - verified Issues that have been released and confirmed resolved. a11y Issues related to Accessibility fixes or improvements. ArcGIS Online Issues logged by ArcGIS Online team members. bug Bug reports for broken functionality. Issues should include a reproduction of the bug. calcite-components Issues specific to the @esri/calcite-components package. estimate - 2 Small fix or update, may require updates to tests. impact - p2 - want for an upcoming milestone User set priority impact status of p2 - want for an upcoming milestone p - high Issue should be addressed in the current milestone, impacts component or core functionality
Projects
None yet
Milestone
2024-11-26 - 3.0.0 Nov Breaking Chang...
Development

No branches or pull requests
5 participants
@mpriour @jcfranco @geospatialem @DitwanP @jasdelreyes