Set zero timestamp for genesis batch #78
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is a workaround to ensure the timestamp of batch 1 (which is determined by the L1 block referred in the HotShot block) is larger than the timestamp of the genesis batch (batch 0).
|
This would probably sync the entire chain so need to be more careful. Edit: No, timestamp doesn't seem to be used in determining what to sync and checking for reorgs. |
jbearer
approved these changes
Sep 26, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a workaround to ensure the timestamp of batch 1 (which is determined by the L1 block referred in the HotShot block) is larger than the timestamp of the genesis batch (batch 0).
For more details see: EspressoSystems/espresso-sequencer#631