Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Refactor] Adding constructors for KZG parameters #440

Open
chancharles92 opened this issue Nov 30, 2023 · 1 comment
Open

[Refactor] Adding constructors for KZG parameters #440

chancharles92 opened this issue Nov 30, 2023 · 1 comment
Labels
T-refactor Type: clean up/refactor

Comments

@chancharles92
Copy link
Contributor

chancharles92 commented Nov 30, 2023

Issue: breaking changes after editing the fields of SRS/VerifierParams:
https://espresso.zulipchat.com/#narrow/stream/330838-Crypto/topic/Powers.20of.20g.2Ch/near/405171215
TODO: Add constructor methods new() for KZG parameters, including SRS, ProverParams, and VerifierParams.

(cc @mrain @ggutoski @alxiong )

@chancharles92 chancharles92 added the T-refactor Type: clean up/refactor label Nov 30, 2023
@alxiong
Copy link
Contributor

alxiong commented Mar 8, 2024

we should also add From<ark_poly_commit::kzg10::UniversalParam> for SRS that avoids expensive memory copy (if possible)

it's possible that in order to avoid mem-copy without unsafe rust, we can only write specialized conversion for concrete types instead of generic function.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
T-refactor Type: clean up/refactor
Projects
None yet
Development

No branches or pull requests

2 participants