Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move entire contentType-specific logic into RequestStrategy #47

Open
kss-espeo opened this issue Jul 23, 2019 · 0 comments
Open

Move entire contentType-specific logic into RequestStrategy #47

kss-espeo opened this issue Jul 23, 2019 · 0 comments
Labels

Comments

@kss-espeo
Copy link
Collaborator

After #32 and #42 , some logic that is specific to contentType is still being done outside of RequestStrategy. This leads to code duplication, worse testability and maintainability.

In scope of this task, refactor exisiting solution to move contentType-speciic logic into RequestStrategy. This will probably mean that contentType enum will be interoduced, Request class will be made abstract and some extensions to it will be created and RequestUrlParser logic will be moved to RequestStrategy. Refer to Code Review comments in #32 and #42 .

While you're at it, it would be nice to add more tests around RequestExecutor logic.

@kss-espeo kss-espeo added the enhancement New feature or request label Jul 23, 2019
@kss-espeo kss-espeo added refactor and removed enhancement New feature or request labels Sep 19, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant