Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Graphene: Resource texts and the modal texts of the Microapps are not readable in the night theme #246

Open
alikemaltanriverdi opened this issue Oct 25, 2022 · 6 comments
Labels
awaiting test Awaiting Test microapps Graphene MicroApps

Comments

@alikemaltanriverdi
Copy link
Collaborator

Description
The text of the resources, the texts in the modals when creating a new/edit script, new/edit template, new/edit forms are not readable in the night theme of the browsers. It seems like the text colors for those mentioned above are white which make them really hard to read in the night theme of the Graphene.

Feature / Subsystem
Graphene

To Reproduce

  1. Go to https://my.binghamton.edu/admin/apps/278
  2. See that the resources are not readable
  3. Go to scripts tab/ templates tab/ forms tab and click on "New/ Edit Name (or New Form/ Edit Form Name)", and see that the text is not readable in the modal

Console Errors
No error

Link(s)
https://my.binghamton.edu/admin/apps/278

Additional context
Please see the screenshots, and let me know if you require any additional documentation.
Resources:
Screen Shot 2022-10-24 at 11 02 05 PM
New/Edit Script:
Screen Shot 2022-10-24 at 11 02 19 PM
New/Edit Template:
Screen Shot 2022-10-24 at 11 02 28 PM

@alikemaltanriverdi alikemaltanriverdi added bug microapps Graphene MicroApps labels Oct 25, 2022
@nwallin1
Copy link
Collaborator

I also have this issue

@Cloverstone
Copy link
Member

Who added a night theme?

@Cloverstone Cloverstone removed the bug label Nov 2, 2022
@timcortesi
Copy link
Member

@Cloverstone -- no idea, not sure if anyone made a deliberate change, but it appears to only have any impact in the Admin view when editing a micro-app. No apparent changes anywhere else on the site including when editing workflows or anywhere else in the admin.

@Cloverstone
Copy link
Member

Yeah - It was a bit tongue-in-cheek. There is no "night theme" - if you set your system to force dark mode then the browser changes defaults but that's all that's happening.

@Cloverstone Cloverstone added the awaiting test Awaiting Test label Nov 2, 2022
Cloverstone added a commit that referenced this issue Nov 2, 2022
add some unique favicons for dev/prod and gateway - some cleanup
@Nynergy
Copy link

Nynergy commented Dec 5, 2022

Following up on this "theme" issue, I can currently read the text on the "Resources" tab of a Microapp edit page just fine, but now the text on all the widgets/sidebar content in the Form Editor is white/blank. This was not the case for me a while ago when the other theme issues were happening, so perhaps there was a code change in the form library that affected only the rendering on the form editor?

@Cloverstone
Copy link
Member

Cloverstone commented Dec 5, 2022 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
awaiting test Awaiting Test microapps Graphene MicroApps
Projects
None yet
Development

No branches or pull requests

5 participants