RTCP CC Feedback payload type value? #17
Comments
|
From what I can see, the only difference is the RTCP packet type. 205 (RTPFB) vs. 207 (XR). The code outside the gstreamer module already uses the correct type (XR). RFC8298 mentions usage of XR, and so does draft-ietf-rmcat-scream-cc-13. draft-ietf-avtcore-cc-feedback-message-03 indeed mentions RTPFB but I don't think the code here currently implements the avtcore-cc-feedback-message signalling, or draft-holmer-rmcat-transport-wide-cc-extensions-01. So from what I understand, the GStreamer code using RTPFB is wrong and it should be XR like in the code outside the GStreamer module until the generalized the generalized feedback messages are implemented. |
|
From my observation. Even we are generating XR(207) packet, it is not included the Packet Receipt Times Report header. when i captured the pcap and verified the feedback XR structure it was showing as malformed.
When i looked in the streamRX.cpp stream->getStandardizedFeedback(time_ntp, &buf[ptr], size_stream); is generating block payload without header and appending directly to the RTCP header. As we are trying to note, the reception times of RTP packets. According to XR standard all the timestamps which we are transmitting in XR block type 3 from above are 32 bit long. But in screamRX they are in 16bit. Is the screamRX, generating feedback, XR standard? |
|
Hi The code implements https://tools.ietf.org/html/draft-ietf-avtcore-cc-feedback-message-02 , and this implies PT=205 (RTPFB). I see that the PT in https://github.com/EricssonResearch/scream/blob/master/code/gscream/gst-gscreamrx/gst-plugin/src/ScreamRx.cpp use the correct PT value. The code in https://github.com/EricssonResearch/scream/blob/master/code/gscream/gst-gscreamrx/gst-plugin/src/gstgscreamrx.cpp#L381 also use RTPFB. One possible error is that I have not set FMT correctly , it is currently zero. With that said.. https://github.com/EricssonResearch/scream/blob/master/code/ScreamRx.cpp actually use PT=207, which is wrong. I will fix this. You may notice that these modules are duplicates, I will merge these later on to reduce the risk of confusion. /Ingemar |
|
Hi As we are using PT=205(RTPFB). According to RFC 4585 FMT value is defined as 1 for Generic NACK. As scream implemented https://tools.ietf.org/html/draft-ietf-avtcore-cc-feedback-message-02. It has mention FMT as CCFB, what is the value for CCFB. i searched for the value but unable to find anywhere. |
|
@saikrishnareddykovvuri or @sdroege / can you share the gstreamer pipes (tx/rx) and network configs that you're testing with? thanks! -pete |
|
Unfortunately i am not using gstreamer. I am working with only the necessary files, integrated into another application and testing. So i can not provide any info related gstreamer. Can you point me to the thread which you started so that i can have a look. |
|
@saikrishnareddykovvuri - -pete |
In mentioned version 2 of avtcore-cc-feedback draft the PT in feed back is mentioned as 205.
But in code gstreamer plugin code is creating the feedback as 205 which was proper. But the streamRX file outside the gstreamer module creating feedback with PT 207.
https://github.com/EricssonResearch/scream/blob/master/code/ScreamRx.cpp
Are the files present outside the gstreamer module uptodate? Can we use the files outside the gstreamer to integrate in the application?
The text was updated successfully, but these errors were encountered: