Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update typings for TypeScript 5.6 #269

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

jdanyow
Copy link

@jdanyow jdanyow commented Sep 30, 2024

Fixes:

../../node_modules/jsep/typings/tsd.d.ts(179,2): error TS1203: 
Export assignment cannot be used when targeting ECMAScript 
modules. Consider using 'export default' or another module 
format instead.

Fixes:
```
../../node_modules/jsep/typings/tsd.d.ts(179,2): error TS1203: 
Export assignment cannot be used when targeting ECMAScript 
modules. Consider using 'export default' or another module 
format instead.
```
@6utt3rfly
Copy link
Collaborator

@jdanyow - thank you for your PR and reporting the issue. The current possible usages of jsep include:

import jsep from '/PATH/TO/jsep.min.js';
import jsep from 'jsep';
import { Jsep } from 'jsep';
import * as jsep from 'jsep';
const jsep = require('jsep').default;
const { Jsep } = require('jsep');

I'm not sure if this proposed PR will work for all of these cases, since it's removing export = jsep. I'm reading that we may need to create a separate typings file for cjs and esm now?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants