[Bug] [0.4.2] [Linux] Bootloader patch creates UpdateFirmware dir in / of local drive instead of mounted sdcard

[xeros]

Looks like 'drive' variable is not getting filled for these lines:

    bootloaderPatchDir = os.path.join(drive,"/UpdateFirmware/")
    bootloaderPatchPathFile = os.path.join(drive,"/UpdateFirmware/Firmware.upk")

in 'bootloaderPatch()', resulting creation of /UpdateFirmware/Firmware.upk instead /mount/point/of/sdcard/UpdateFirmware/Firmware.upk.

Tested first with as regular user and got permissions error about trying to create /UpdateFirmware/, then run as root and got the path and file (/UpdateFirmware/Firmware.upk) created, but in root of filesystem instead of sdcard.

Looks like the 'drive' variable here (few lines up) was set to null or empty string instead of 'N/A' or path:
drive = window.combobox_drive.currentText()
if drive == "N/A":

so the rest of code proceeded further.

It's strange as it looks similar to other options that need to read or write something on sdcard and these options (other fixes, roms edits, etc.) work fine, but it failed in above code few times in a row for the same option (sdcard was not unmounted or re-inserted in meantime).

[xeros]

Full log, with error message and previous successful operations:

myuser:tadpole-0.4.2$ python tadpole.py
establishing tadpole config
Warning: Ignoring XDG_SESSION_TYPE=wayland on Gnome. Use QT_QPA_PLATFORM=wayland to run on Wayland anyway.
New drive detected
Running frogtool with drive (/run/media/myuser/C2A6-503B) and console (FC)
Processing FC
Backing up /run/media/myuser/C2A6-503B/Resources/rdbui.tax as /run/media/myuser/C2A6-503B/Resources/rdbui.tax_orig
Backing up /run/media/myuser/C2A6-503B/Resources/fhcfg.nec as /run/media/myuser/C2A6-503B/Resources/fhcfg.nec_orig
Backing up /run/media/myuser/C2A6-503B/Resources/nethn.bvs as /run/media/myuser/C2A6-503B/Resources/nethn.bvs_orig
Looking for files in /run/media/myuser/C2A6-503B/FC
Overwriting /run/media/myuser/C2A6-503B/Resources/rdbui.tax
Overwriting /run/media/myuser/C2A6-503B/Resources/fhcfg.nec
Overwriting /run/media/myuser/C2A6-503B/Resources/nethn.bvs
Done

Result Finished updating FC with 877 ROMs
loading roms to table for (/run/media/myuser/C2A6-503B) (FC)
Found 877 ROMs
finished loading roms to table
Tadpole~DetectOSVersion: Trying to read bisrv hash
trying to read /run/media/myuser/C2A6-503B/bios/bisrv.asd
Finished reading file
Blanked CRC32
start finding logo
finished finding logo
Blanked Bootlogo
starting to compute hash
Hash: 334c8f0a8584db07078d7dfc940e540e6538dde948cb6fdbf50754e4e113d6bc
File '/run/media/myuser/C2A6-503B/bios/bisrv.asd' opened successfully.
The firmware does not match the expected battery patched versions at offset 3564EC. Please check the offsets.
The firmware matched the expected firmware versions at offset 3565B0.
File '/run/media/myuser/C2A6-503B/bios/bisrv.asd' opened successfully.
The firmware matched the expected firmware versions at offset 3565B0.
File patched with new battery values.
Calculating new CRC32...
New CRC32 value: 85DA577D
Patched data written back to '/run/media/myuser/C2A6-503B/bios/bisrv.asd'.
Traceback (most recent call last):
File "/home/myuser/Downloads/SF2000/tadpole/tadpole-0.4.2/tadpole.py", line 398, in bootloaderPatch
os.mkdir(bootloaderPatchDir)
PermissionError: [Errno 13] Permission denied: '/UpdateFirmware/'

myuser:tadpole-0.4.2$