Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move shared folder to be under mainmodule and not server #1686

Open
ccuser44 opened this issue Nov 7, 2024 · 2 comments · May be fixed by #1689
Open

Move shared folder to be under mainmodule and not server #1686

ccuser44 opened this issue Nov 7, 2024 · 2 comments · May be fixed by #1689
Labels
✨ enhancement Enhancing or improving existing functionality

Comments

@ccuser44
Copy link
Contributor

ccuser44 commented Nov 7, 2024

What part of Adonis is this related to?

GitHub Repository

What are you suggesting?

Move shared folder to be under MainModule and not server. This makes it consistent.
Also a backwards compatibility feature should be added to Misc_Features.luau to set a proxy for the last location.
@ccuser44 ccuser44 added the ✨ enhancement Enhancing or improving existing functionality label Nov 7, 2024
@EasternBloxxer
Copy link
Contributor

Only good suggestion from you

@EasternBloxxer
Copy link
Contributor

image

@ccuser44 ccuser44 linked a pull request Nov 8, 2024 that will close this issue
Draft
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
✨ enhancement Enhancing or improving existing functionality
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Move shared to MainModule ccuser44/Adonis
2 participants
@EasternBloxxer @ccuser44