Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Recover Frames‘s interval is too short #31

Open
Mishasama opened this issue Aug 31, 2024 · 4 comments
Open

Recover Frames‘s interval is too short #31

Mishasama opened this issue Aug 31, 2024 · 4 comments
Assignees
@Ephellon
Labels
enhancement this item makes the project better in some way forked this was implemented in the newer version(s) from a fork/merge in-progress this item is being worked on

Comments

@Mishasama
Copy link

Steps:

  1. Watch a stream
  2. Switch to other tabs
  3. Wait for a network problem causing the video to stop (stuck at not enough cache)
  4. Switch back to the stream tab
  5. You will see it constantly pause and resume playback for short periods.

When we need this function, it means that our network or hardware has a problem that cannot be quickly fixed.
I recommend waiting at least 10 seconds between each recovery attempt. And you may need to consider tabs in the background.

Originally posted by @Mishasama in #27 (comment)
@Ephellon Ephellon added bug this item causes errors that make the project unusable enhancement this item makes the project better in some way forked this was implemented in the newer version(s) from a fork/merge in-progress this item is being worked on labels Aug 31, 2024
@Ephellon Ephellon self-assigned this Aug 31, 2024
@Ephellon
Copy link
Owner

Intended outcome. Will try 15s in next beta

@Ephellon Ephellon removed the bug this item causes errors that make the project unusable label Aug 31, 2024
@Ephellon
Copy link
Owner

tools.js:15323

Timers.recover_video = 5000; // Change to `10_000`

@Mishasama
Copy link
Author

Intended outcome. Will try 15s in next beta

Will this time be deferred from execution by the browser because the tab is in the background? (Like Android's doze aligned wakeup) This could potentially cause timer stacking.

@Ephellon
Copy link
Owner

I could use the onpagehide event

Ephellon added a commit that referenced this issue Sep 17, 2024
@Ephellon
- Changed some event timings on Settings Page to help with CPU usage
29431de 
- Changed `Recover Video` timer to `10s` as per #31
- Modified channel point ranking logic to include scaling
- Updated Pinned Streamer styling
- Modified time zone logic
- Modified `ClipName`
- Modified ranking logic
- Fixed **New Feature** logic
- Added `Block Banners` setting
- Modified `Recover Frames` logic
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Ephellon Ephellon

Labels
enhancement this item makes the project better in some way forked this was implemented in the newer version(s) from a fork/merge in-progress this item is being worked on
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@Ephellon @Mishasama