Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug]: Files uploading with empty content #276

Closed
3 tasks done
KorvinSzanto opened this issue Jan 18, 2024 · 6 comments
Closed
3 tasks done

[Bug]: Files uploading with empty content #276

KorvinSzanto opened this issue Jan 18, 2024 · 6 comments
Assignees
Labels
🐛 Bug Something isn't working

Comments

@KorvinSzanto
Copy link

Issue validation

  • I checked the issue to prevent duplicate
  • I checked my configurations files and the documentation
  • My issue concern doesn't concern the Mkdocs template

Command used

Upload all notes

Plugin version

6.13.5

Describe the bug

Uploading new notes leads to files uploaded with effectively empty content:

---
{}
---

How to reproduce ?

  1. Enable share all notes
  2. Upload all notes

Minimal Reproducible Example

## This file is empty
- Foo
- Baz

Configuration

{
  "github": {
    "branch": "main",
    "automaticallyMergePR": true,
    "tokenPath": "%configDir%/plugins/%pluginID%/env",
    "api": {
      "tiersForApi": "Github Free/Pro/Team (default)",
      "hostname": ""
    },
    "workflow": {
      "commitMessage": "[PUBLISHER] Merge",
      "name": ""
    },
    "verifiedRepo": true
  },
  "upload": {
    "behavior": "obsidian",
    "defaultName": "",
    "rootFolder": "",
    "yamlFolderKey": "",
    "frontmatterTitle": {
      "enable": false,
      "key": "title"
    },
    "replaceTitle": [],
    "replacePath": [],
    "autoclean": {
      "enable": false,
      "excluded": []
    },
    "folderNote": {
      "enable": false,
      "rename": "index.md",
      "addTitle": {
        "enable": false,
        "key": "title"
      }
    },
    "metadataExtractorPath": ""
  },
  "conversion": {
    "hardbreak": false,
    "dataview": true,
    "censorText": [],
    "tags": {
      "inline": false,
      "exclude": [],
      "fields": []
    },
    "links": {
      "internal": false,
      "unshared": true,
      "wiki": false,
      "slugify": false
    }
  },
  "embed": {
    "attachments": true,
    "overrideAttachments": [],
    "keySendFile": [],
    "notes": false,
    "folder": "",
    "convertEmbedToLinks": "keep",
    "charConvert": "->"
  }
}

Relevant log output

No response

OS

MacOS

Anything else?

Some files upload properly but others are blank/empty.

Obsidian information

SYSTEM INFO:
	Obsidian version: v1.5.3
	Installer version: v1.4.16
	Operating system: Darwin Kernel Version 23.2.0: Wed Nov 15 21:55:06 PST 2023; root:xnu-10002.61.3~2/RELEASE_ARM64_T6020 23.2.0
	Login status: not logged in
	Insider build toggle: off
	Live preview: on
	Base theme: adapt to system
	Community theme: none
	Snippets enabled: 0
	Restricted mode: off
	Plugins installed: 2
	Plugins enabled: 1
		1: Github Publisher v6.13.5

RECOMMENDATIONS:
	Community plugins: for bugs, please first try updating all your plugins to latest. If still not fixed, please try to make the issue happen in the Sandbox Vault or disable community plugins.
@KorvinSzanto KorvinSzanto added the 🐛 Bug Something isn't working label Jan 18, 2024
@Mara-Li
Copy link
Member

Mara-Li commented Jan 18, 2024

Do you share file without sharing key?

@KorvinSzanto
Copy link
Author

KorvinSzanto commented Jan 18, 2024

Do you share file without sharing key?

I don't understand the question, can you ask in a different way?
I have the plugin configured to share all files and to use the obsidian path as the key.

@Mara-Li
Copy link
Member

Mara-Li commented Jan 18, 2024

The option is in the last tabs, first option. Share without key, tabs "plugins settings"

@KorvinSzanto
Copy link
Author

Yeah I have "Share all files" enabled which mentions the key, I don't see a setting called "Share without key" otherwise:
image

@Mara-Li
Copy link
Member

Mara-Li commented Jan 18, 2024

Well, it's just a resume of the option ^^". I named it like that somewhere in the code.

@Mara-Li
Copy link
Member

Mara-Li commented Jan 18, 2024

Should be fixed!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🐛 Bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants