Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug]: Images & Tables #244

Closed
3 tasks done
mclearc opened this issue Nov 13, 2023 · 1 comment
Closed
3 tasks done

[Bug]: Images & Tables #244

mclearc opened this issue Nov 13, 2023 · 1 comment
Assignees
Labels
❌ Invalid This doesn't seem right

Comments

@mclearc
Copy link

mclearc commented Nov 13, 2023

Issue validation

  • I checked the issue to prevent duplicate
  • I checked my configurations files and the documentation
  • My issue concern doesn't concern the Mkdocs template

Command used

Upload single current active note

Plugin version

6.10.3

Describe the bug

Links to images in tables that set a size require use of "|". But this gets escaped in the export, and the mkdocs site builder can't read the escaped links, and so the image doesn't render. If I alter the file directly on GitHub to remove the "" marks before the pipes everything works fine.

How to reproduce ?

  1. Create a table with image links using obsidian syntax for setting size -- e.g. [[image-link|75]].
  2. Export table using publisher
  3. Links break :(

Minimal Reproducible Example

---
share: true
date created: Sunday, September 17th 2023, 6:38:42 pm
date modified: Wednesday, November 1st 2023, 11:38:26 pm
---

The party members are as follows: 

| Art                                                 | PC                                                           | Quick Stats                                             | Ancestry | Background    | Class                 | Proficiencies                                                                                      | Languages                       |
| --------------------------------------------------- | ------------------------------------------------------------ | ------------------------------------------------------- | -------- | ------------- | --------------------- | -------------------------------------------------------------------------------------------------- | ------------------------------- |
| ![[../../assets/img/gloopwing.png\|75]]             | [[./Gloopwing\|Gloopwing]]               | :rif_eye:10 :rif_spy:11<br>:rif_shield:18 :fas_heart:13 | Plasmoid | Haunted One   | Fighter<br> (lvl 2)   | Arcana, History, Insight, Religion<br>Strength, Constitution                                       | Common, Draconic, Giant, Goblin |
| ![[../../assets/img/pc-gwen.jpeg\|75]]              | [[./Gwenzahlya\|Gwenzahlya]]             | :rif_eye:12 :rif_spy:14<br>:rif_shield:18 :fas_heart:14 | Doloi    | Spirit Medium | Wizard<br> (lvl 2)    | Arcana, Investigation, Perception, Performance<br>Intelligence, Wisdom                             | Common, Goblin                  |
| ![[../../assets/img/pc-karel.jpg\|75]]              | [[./Karel\|Karel]]                       | :rif_eye:10 :rif_spy:13<br>:rif_shield:16 :fas_heart:21 | Human    | Renegade      | Pugilist<br> (lvl 2)  | Athletics, Insight, Intimidation, Survival<br>Strength, Constitution                               | Common                          |
| ![[../../assets/img/faeir-feline.png\|75]]          | [[./Ryalith-Seraphia\|Ryalith Seraphia]] | :rif_eye:12 :rif_spy:12<br>:rif_shield:16 :fas_heart:22 | Faeir    | Criminal      | Pugilist<br> (lvl 2)  | Athletics, Deception, Perception, Stealth<br>Strength, Constitution                                | Common, Faeir                   |
| ![[../../assets/img/er_dhampir-portrait_5.png\|75]] | [[./Stigs-the-Stiff\|Stigs the Stiff]]   | :rif_eye:13 :rif_spy:15<br>:rif_shield:16 :fas_heart:17 | Dhampir  | Shipwright    | Artificer<br> (lvl 2) | Arcana, History, Investigation, Perception, Sleight of Hand, Stealth<br>Constitution, Intelligence | Common                          |

Configuration

{
  "github": {
    "branch": "main",
    "automaticallyMergePR": true,
    "tokenPath": "%configDir%/plugins/%pluginID%/env",
    "api": {
      "tiersForApi": "Github Free/Pro/Team (default)",
      "hostname": ""
    },
    "workflow": {
      "commitMessage": "Merge",
      "name": ""
    },
    "verifiedRepo": true
  },
  "upload": {
    "behavior": "obsidian",
    "defaultName": "docs",
    "rootFolder": "",
    "yamlFolderKey": "",
    "frontmatterTitle": {
      "enable": false,
      "key": "title"
    },
    "replaceTitle": [
      {
        "regex": "/\\s/gi",
        "replacement": "-",
        "type": "title"
      }
    ],
    "replacePath": [
      {
        "regex": "/\\s/gi",
        "replacement": "-",
        "type": "path"
      }
    ],
    "autoclean": {
      "enable": true,
      "excluded": [
        "docs/assets/js",
        "docs/assets/meta",
        "docs/assets/css",
        "tags.md",
        "graph.md"
      ]
    },
    "folderNote": {
      "enable": true,
      "rename": "index.md"
    },
    "metadataExtractorPath": ""
  },
  "conversion": {
    "hardbreak": false,
    "dataview": true,
    "censorText": [],
    "tags": {
      "inline": false,
      "exclude": [],
      "fields": []
    },
    "links": {
      "internal": true,
      "unshared": false,
      "wiki": false,
      "slugify": false
    }
  },
  "embed": {
    "attachments": true,
    "keySendFile": [],
    "notes": false,
    "folder": "docs/assets/img",
    "convertEmbedToLinks": "keep",
    "charConvert": "->"
  }
}

Relevant log output

No response

OS

No response

Anything else?

Here's the link on the active site: https://lichfactory.com/ad-astra/the-party/

Obsidian information

SYSTEM INFO:
	Obsidian version: v1.4.16
	Installer version: v1.4.13
	Operating system: Darwin Kernel Version 23.1.0: Mon Oct  9 21:28:45 PDT 2023; root:xnu-10002.41.9~6/RELEASE_ARM64_T6020 23.1.0
	Login status: not logged in
	Insider build toggle: off
	Live preview: off
	Legacy editor: off
	Base theme: adapt to system
	Community theme: Typomagical v1.9.1
	Snippets enabled: 14
	Restricted mode: off
	Plugins installed: 51
	Plugins enabled: 41
		1: Admonition v10.1.1
		2: Advanced Tables v0.19.1
		3: Auto Note Mover v1.2.0
		4: Better Word Count v0.10.0
		5: Buttons v0.4.19
		6: Dataview v0.5.64
		7: Dice Roller v10.4.0
		8: Excalidraw v1.9.28
		9: Excel to Markdown Table v0.4.0
		10: Export Image plugin v1.0.3
		11: Fantasy Statblocks v3.16.0
		12: Github Publisher v6.10.3
		13: Folder notes v1.6.11
		14: Icon Shortcodes v0.9.7
		15: JS Engine v0.0.5
		16: Meta Bind Plugin v0.7.2
		17: Initiative Tracker v12.4.2
		18: Webpage HTML Export v1.7.3
		19: Various Complements v9.1.0
		20: Text Mapper v1.0.0
		21: Text Format v2.2.8
		22: Settings Search v1.3.10
		23: Table Extended v1.6.1
		24: Quick Switcher++ v3.3.8
		25: Pandoc Plugin v0.4.1
		26: Obsidian Enhancing Export v1.9.2
		27: Obsidian42 - BRAT v0.7.1
		28: Obsidian Leaflet v6.0.0
		29: JSON/CSV Importer v0.31.2
		30: Tag Wrangler v0.6.1
		31: Link with alias v1.0.7
		32: Note Auto Creator v10
		33: Iconize v2.7.3
		34: Style Settings v1.0.7
		35: Hover Editor v0.11.15
		36: Hover External Link Plugin v1.0.0
		37: Custom Frames v2.4.6
		38: CSS Editor v0.5.0
		39: Text Generator v0.5.13
		40: Image Toolkit v1.4.0
		41: Linter v1.20.1

RECOMMENDATIONS:
	Custom theme and snippets: for cosmetic issues, please first try updating your theme and disabling your snippets. If still not fixed, please try to make the issue happen in the Sandbox Vault or disable community theme and snippets.
	Community plugins: for bugs, please first try updating all your plugins to latest. If still not fixed, please try to make the issue happen in the Sandbox Vault or disable community plugins.
@mclearc mclearc added the 🐛 Bug Something isn't working label Nov 13, 2023
@Mara-Li
Copy link
Member

Mara-Li commented Nov 13, 2023

  1. Wrong repository
  2. I don't think it's possible to get around that. Mkdocs table are pretty limited, and the reading of Wikilinks is complicated. The table is automatically broken if you don't have the escaping of \|

The best way to create a grid is to use callout grid, you will get a pretty good snippet in the ITS repository and the blog will support it natively.

@Mara-Li Mara-Li closed this as not planned Won't fix, can't repro, duplicate, stale Nov 13, 2023
@Mara-Li Mara-Li added ❌ Invalid This doesn't seem right and removed 🐛 Bug Something isn't working labels Nov 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
❌ Invalid This doesn't seem right
Projects
None yet
Development

No branches or pull requests

2 participants