Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Plugin][Bug]: Failed to parse expression when inline DV #235

Closed
ooker777 opened this issue Oct 21, 2023 · 6 comments
Closed

[Plugin][Bug]: Failed to parse expression when inline DV #235

ooker777 opened this issue Oct 21, 2023 · 6 comments
Assignees
Labels
🐛 Bug Something isn't working 💎 Obsidian Github Publisher Related to the plugin 🆘 Help wanted Extra attention is needed : the maintener need external help

Comments

@ooker777
Copy link
Contributor

ooker777 commented Oct 21, 2023

Make a new vault and a new note with this content:

---
share: true
---
text before `=` text middle `random word`

Then the output with be:

`=` text middle `

For now I can work around by adding a space before the inline DQL:

text before ` =` text middle `random word`

Plugins installed:
1: Github Publisher v6.10.2
2: Dataview v0.5.61

Configuration

{
  "github": {
    "branch": "main",
    "automaticallyMergePR": true,
    "api": {
      "tiersForApi": "Github Free/Pro/Team (default)",
      "hostname": ""
    },
    "workflow": {
      "name": "",
      "commitMessage": "[skip netlify] PUBLISHER"
    },
    "verifiedRepo": true
  },
  "upload": {
    "behavior": "obsidian",
    "subFolder": "",
    "defaultName": "docs",
    "rootFolder": "docs",
    "yamlFolderKey": "category",
    "frontmatterTitle": {
      "enable": true,
      "key": "filename"
    },
    "replaceTitle": [],
    "autoclean": {
      "enable": true,
      "excluded": [
        "docs/assets/js",
        "docs/assets/meta",
        "docs/assets/css",
        "tags.md",
        "graph.md"
      ]
    },
    "folderNote": {
      "enable": false,
      "rename": "index.md"
    },
    "metadataExtractorPath": "",
    "replacePath": []
  },
  "conversion": {
    "hardbreak": false,
    "dataview": true,
    "censorText": [
      {
        "entry": "10. PROJECT/ETERNITY/Wiki/Personnages",
        "replace": "",
        "after": true
      }
    ],
    "tags": {
      "inline": true,
      "exclude": [],
      "fields": []
    },
    "links": {
      "internal": true,
      "unshared": false,
      "wiki": true,
      "slugify": true
    }
  },
  "embed": {
    "attachments": true,
    "keySendFile": [
      "image"
    ],
    "notes": true,
    "folder": "docs/assets/attachments"
  },
  "tabsID": "github-configuration"
}
@ooker777 ooker777 added 🐛 Bug Something isn't working 💎 Obsidian Github Publisher Related to the plugin labels Oct 21, 2023
@Mara-Li
Copy link
Member

Mara-Li commented Oct 21, 2023

The approache around dataview is pretty tricky and there are some problem with the last update, as the API wasn't updated correctly.

I prefer to don't touch it for the moment, waiting for a proper update of the dataview API that will add a better support of in-lineDQL and DJS.

The inlineDQL support exists, but the API bug and I can't update to support it for the moment.

Maybe ask in the dataview issue to get some update ?

blacksmithgu/obsidian-dataview#2080

@Mara-Li Mara-Li added the 🆘 Help wanted Extra attention is needed : the maintener need external help label Oct 21, 2023
@Mara-Li
Copy link
Member

Mara-Li commented Nov 5, 2023

Okay, with the last version of Dataview, it seems you can't use "text before = text middle random word"
image

Advice:

  • Change the inline key to something you won't use in your daily life
  • Use the space between the space

Close as it not a error from Obs-Publisher

@Mara-Li Mara-Li closed this as not planned Won't fix, can't repro, duplicate, stale Nov 5, 2023
@ooker777
Copy link
Contributor Author

ooker777 commented Nov 5, 2023

Hmm, is it possible to make the error intact? That is, if DV prints an error, then the output prints it and not trim any text surrounding it. Or better print the query or simply dataview incorrect query

@Mara-Li
Copy link
Member

Mara-Li commented Nov 5, 2023

No. It's not possible.

By the way. The file needs to be correct before you publish. The plugin won't correct this for you.

@ooker777
Copy link
Contributor Author

ooker777 commented Nov 5, 2023

Why is it not possible?

@Mara-Li
Copy link
Member

Mara-Li commented Nov 5, 2023

Because the API doesn't work like that.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🐛 Bug Something isn't working 💎 Obsidian Github Publisher Related to the plugin 🆘 Help wanted Extra attention is needed : the maintener need external help
Projects
None yet
Development

No branches or pull requests

2 participants