Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create a plan modifier for pe_allowed_principal_ids and service_account_ids #339

Open
serdardalgic opened this issue Sep 13, 2023 · 0 comments
Labels
bug Something isn't working go Pull requests that update Go code good first issue Good for newcomers

Comments

@serdardalgic
Copy link
Contributor

Within the biganimal_cluster resource, we manage the mentioned fields here.

This logic is basically a plan modifier, and it doesn't handle the cases when the user provides non-nil empty slices, for example, in the resource.tf

resource "biganimal_cluster" "single_node_cluster" {
...
...
  pe_allowed_principal_ids = [ ]

  service_account_ids = [ ]

This logic can be moved to a custom planmodifier for those values under /pkg/plan_modifier and we can cover the case when the value is an empty slice.

@serdardalgic serdardalgic added bug Something isn't working good first issue Good for newcomers go Pull requests that update Go code labels Sep 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working go Pull requests that update Go code good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

1 participant