From e0bbccff0e4d7033724eca7a3e8ee3ea4e261bfd Mon Sep 17 00:00:00 2001 From: Tao Li Date: Mon, 25 Nov 2024 19:46:36 +0800 Subject: [PATCH] fix e2e deploy for lts sub-chart Signed-off-by: Tao Li --- .github/workflows/continuous-delivery.yml | 2 ++ README.md | 14 +++++++++++--- 2 files changed, 13 insertions(+), 3 deletions(-) diff --git a/.github/workflows/continuous-delivery.yml b/.github/workflows/continuous-delivery.yml index ee57ebd..b30b312 100644 --- a/.github/workflows/continuous-delivery.yml +++ b/.github/workflows/continuous-delivery.yml @@ -90,6 +90,7 @@ jobs: run: | helm upgrade --install edb-pg4k-lts --namespace postgresql-operator-system \ --create-namespace charts/edb-postgres-distributed-for-kubernetes/charts/edb-postgres-for-kubernetes-lts \ + --set image.imageCredentials.create=true \ --set image.imageCredentials.username=${{ secrets.CS_USER }} \ --set image.imageCredentials.password=${{ secrets.CS_PASSWORD }} \ --wait --timeout 10m @@ -213,6 +214,7 @@ jobs: helm upgrade --install edb-pg4k-lts --namespace single-install \ --set config.clusterWide=false \ --create-namespace charts/edb-postgres-distributed-for-kubernetes/charts/edb-postgres-for-kubernetes-lts \ + --set image.imageCredentials.create=true \ --set image.imageCredentials.username=${{ secrets.CS_USER }} \ --set image.imageCredentials.password=${{ secrets.CS_PASSWORD }} \ --wait --timeout 10m diff --git a/README.md b/README.md index baf062a..85ca444 100644 --- a/README.md +++ b/README.md @@ -288,6 +288,8 @@ To deploy PG4K-PGD with all dependencies together helm upgrade --install edb-pg4k-pgd \ --namespace pgd-operator-system \ --create-namespace \ + --set image.imageCredentials.username=${USERNAME} \ + --set image.imageCredentials.password=${PASSWORD} \ charts/edb-postgres-distributed-for-kubernetes ``` @@ -297,21 +299,27 @@ To deploy the PG4K LTS subchart separately in a different namespace. helm upgrade --install edb-pg4k-lts \ --namespace postgresql-operator-system \ --create-namespace \ + --set image.imageCredentials.create=true \ + --set image.imageCredentials.username=${USERNAME} \ + --set image.imageCredentials.password=${PASSWORD} \ charts/edb-postgres-distributed-for-kubernetes/charts/edb-postgres-for-kubernetes-lts ``` -and then deploy the PG4K-PGD chart. +and then deploy the PG4K-PGD chart with `edb-postgres-for-kubernetes-lts.enabled=false` +set. ``` helm upgrade --install edb-pg4k-pgd \ --namespace pgd-operator-system \ --create-namespace \ + --set image.imageCredentials.username=${USERNAME} \ + --set image.imageCredentials.password=${PASSWORD} \ charts/edb-postgres-distributed-for-kubernetes \ --set edb-postgres-for-kubernetes-lts.enabled=false ``` -**Note:** The image locations and the credentials are elided. Please refer to -the sections above for directions. +**Note:** The image locations are elided. Please refer to the sections above +for directions. If you update the version of the dependency charts and want to install from source, remember to run `helm dependency update` and `helm dependency build` in