From 877a628ebb3ad9e0928587a6bf801fb4b32d4a3f Mon Sep 17 00:00:00 2001 From: Semab-Tariq Date: Tue, 30 Nov 2021 14:08:26 +0500 Subject: [PATCH 1/4] [PPS-54] - Fixing some warnings that installbuilder throws during installer build - Removing code from server/*.xml.in files related to unsupported platforms --- server/commandlinetools.xml.in | 81 ----------------------- server/installer.xml.in | 39 ----------- server/pgadmin.xml.in | 115 --------------------------------- server/stackbuilder.xml.in | 114 +------------------------------- 4 files changed, 1 insertion(+), 348 deletions(-) diff --git a/server/commandlinetools.xml.in b/server/commandlinetools.xml.in index b53fcf30d..9d5a13cb1 100755 --- a/server/commandlinetools.xml.in +++ b/server/commandlinetools.xml.in @@ -39,51 +39,6 @@ - - - Program Files - ${installdir} - programfileslinux-x64 - linux-x64 - - - staging/linux-x64/commandlinetools/lib - - - staging/linux-x64/commandlinetools/bin - - - staging/linux-x64/commandlinetools/share - - - staging/linux-x64/commandlinetools/installer - - - staging/linux-x64/commandlinetools/scripts - - - staging/linux-x64/commandlinetools/commandlinetools_3rd_party_licenses.txt - - - - - - Program Files - ${installdir} - programfileslinux-ppc64 - linux-ppc - - - staging/linux-ppc64/pgAdmin 4 - - - ../resources/license.txt - - - staging/linux-ppc64/server_3rd_party_licenses.txt - - - Program Files @@ -135,42 +90,6 @@ - - - Program Files - ${installdir} - programfilessolaris-x64 - solaris-intel - - - staging/solaris-x64/pgAdmin 4 - - - ../resources/license.txt - - - staging/solaris-x64/server_3rd_party_licenses.txt - - - - - - Program Files - ${installdir} - programfilessolaris-sparc - solaris-sparc - - - staging/solaris-sparc/pgAdmin 4 - - - ../resources/license.txt - - - staging/solaris-sparc/server_3rd_party_licenses.txt - - - diff --git a/server/installer.xml.in b/server/installer.xml.in index 8b71724ac..2921ff5c6 100755 --- a/server/installer.xml.in +++ b/server/installer.xml.in @@ -729,8 +729,6 @@ EOF - - @@ -1252,21 +1250,6 @@ EOF - - default - ${system_temp_directory}/postgresql_installer_${random_number} - defaultlinux-x64 - prerun_checks.sh - ${msg(error.writing.temp)} - - - equals - ${platform_name} - linux-x64 - - - - default ${system_temp_directory}/postgresql_installer_${random_number} @@ -2070,28 +2053,6 @@ ${dbsummary}${cltsummary}${pgadminsummary}${sbsummary}${msg(summary.installation - - - Program Files - ${installdir}/installer/server - defaultlinux-x64 - linux-x64 - - - staging/linux-x64/server/installer/prerun_checks.sh - - - staging/linux-x64/server/scripts - - - - - contains - ${platform_name} - linux-x64 - - - Program Files diff --git a/server/pgadmin.xml.in b/server/pgadmin.xml.in index 8d0873915..03ec3eb4c 100755 --- a/server/pgadmin.xml.in +++ b/server/pgadmin.xml.in @@ -51,85 +51,6 @@ - - Program Files - ${installdir}/server/scripts - scriptfileslinux_2 - linux4 - - - staging/linux/pgadmin4/scripts/xdg - - - - - does_not_equal - ${platform_name} - linux-x64 - - - - - - Program Files - ${installdir} - programfileslinux-x64 - linux-x64 - - - staging/linux-x64/pgadmin4/pgAdmin 4 - - - staging/linux-x64/pgadmin4/pgAdmin_3rd_party_licenses.txt - - - staging/linux-x64/pgadmin4/pgAdmin_license.txt - - - - - Script Files - ${installdir} - scriptfileslinux-x64 - linux-x64 - - - staging/linux-x64/pgadmin4/scripts - - - staging/linux-x64/pgadmin4/installer - - - - - Program Files - ${installdir}/server/scripts - scriptfileslinux-x64_2 - linux-x64 - - - staging/linux-x64/pgadmin4/scripts/xdg - - - - - - Program Files - ${installdir} - programfileslinux-ppc64 - linux-ppc - - - staging/linux-ppc64/pgAdmin 4 - - - ../resources/license.txt - - - staging/linux-ppc64/server_3rd_party_licenses.txt - - - Program Files @@ -175,42 +96,6 @@ - - - Program Files - ${installdir} - programfilessolaris-x64 - solaris-intel - - - staging/solaris-x64/pgAdmin 4 - - - ../resources/license.txt - - - staging/solaris-x64/server_3rd_party_licenses.txt - - - - - - Program Files - ${installdir} - programfilessolaris-sparc - solaris-sparc - - - staging/solaris-sparc/pgAdmin 4 - - - ../resources/license.txt - - - staging/solaris-sparc/server_3rd_party_licenses.txt - - - diff --git a/server/stackbuilder.xml.in b/server/stackbuilder.xml.in index b42b9ca58..49fca7f4a 100755 --- a/server/stackbuilder.xml.in +++ b/server/stackbuilder.xml.in @@ -91,82 +91,6 @@ - - - Program Files - ${installdir} - programfileslinux-x64 - linux-x64 - - - staging/linux-x64/stackbuilder/scripts - - - staging/linux-x64/stackbuilder/StackBuilder_3rd_party_licenses.txt - - - - - Program Files - ${installdir}/stackbuilder - programfileslinux-x64_1 - linux-x64 - - - staging/linux-x64/stackbuilder/bin - - - staging/linux-x64/stackbuilder/lib - - - staging/linux-x64/stackbuilder/share - - - - - Program Files - ${installdir}/stackbuilder/installer - programfileslinux-x64_2 - linux-x64 - - - */server - staging/linux-x64/stackbuilder/installer/* - - - - - Program Files - ${installdir}/installer/server - programfileslinux-x64_3 - linux-x64 - - - staging/linux-x64/stackbuilder/installer/server/createshortcuts_sb.sh - - - staging/linux-x64/stackbuilder/installer/server/removeshortcuts_sb.sh - - - - - - Program Files - ${installdir} - programfileslinux-ppc64 - linux-ppc - - - staging/linux-ppc64/stackbuilder - - - ../resources/license.txt - - - staging/linux-ppc64/server_3rd_party_licenses.txt - - - Program Files @@ -209,43 +133,7 @@ - - - Program Files - ${installdir} - programfilessolaris-x64 - solaris-intel - - - staging/solaris-x64/stackbuilder - - - ../resources/license.txt - - - staging/solaris-x64/server_3rd_party_licenses.txt - - - - - - Program Files - ${installdir} - programfilessolaris-sparc - solaris-sparc - - - staging/solaris-sparc/stackbuilder - - - ../resources/license.txt - - - staging/solaris-sparc/server_3rd_party_licenses.txt - - - - + From 04e38efe778901e027f6329dd683cfee31eede9d Mon Sep 17 00:00:00 2001 From: Semab-Tariq Date: Tue, 30 Nov 2021 15:15:33 +0500 Subject: [PATCH 2/4] [PPS-54] - Removing unsupported platforms code --- server/installer.xml.in | 28 ---------------------------- 1 file changed, 28 deletions(-) diff --git a/server/installer.xml.in b/server/installer.xml.in index 2921ff5c6..7de4dae8d 100755 --- a/server/installer.xml.in +++ b/server/installer.xml.in @@ -1265,34 +1265,6 @@ EOF - - default - ${system_temp_directory}/postgresql_installer_${random_number} - programfilessolaris-x64 - server/installer/prerun_checks.sh - - - equals - ${platform_name} - solaris-intel - - - - - - default - ${system_temp_directory}/postgresql_installer_${random_number} - programfilessolaris-sparc - server/installer/prerun_checks.sh - - - equals - ${platform_name} - solaris-sparc - - - - From d67cbe7a169c5ff6741d411f9b933ad4142ca96f Mon Sep 17 00:00:00 2001 From: Semab-Tariq Date: Tue, 30 Nov 2021 16:00:57 +0500 Subject: [PATCH 3/4] [PPS-54] - Removing unsupported platforms and cleaning the script files --- server/pgserver.xml.in | 317 ----------------------------------------- 1 file changed, 317 deletions(-) diff --git a/server/pgserver.xml.in b/server/pgserver.xml.in index 14b79240b..cd3bc0051 100755 --- a/server/pgserver.xml.in +++ b/server/pgserver.xml.in @@ -46,75 +46,6 @@ - - - Program Files - ${installdir} - programfileslinux-x64 - linux-x64 - - - staging/linux-x64/server/bin - - - staging/linux-x64/server/doc - - - staging/linux-x64/server/include - - - staging/linux-x64/server/installer - - - staging/linux-x64/server/scripts - - - staging/linux-x64/server/share - - - staging/linux-x64/server/etc - - - staging/linux-x64/server/server_license.txt - - - - - - Program Files - ${installdir} - programfileslinux-ppc64 - linux-ppc - - - staging/linux-ppc64/bin - - - staging/linux-ppc64/doc - - - staging/linux-ppc64/include - - - staging/linux-ppc64/installer - - - staging/linux-ppc64/lib - - - staging/linux-ppc64/scripts - - - staging/linux-ppc64/share - - - ../resources/license.txt - - - staging/linux-ppc64/server_3rd_party_licenses.txt - - - Program Files @@ -181,81 +112,7 @@ - - - Program Files - ${installdir} - programfilessolaris-x64 - solaris-intel - - - staging/solaris-x64/bin - - - staging/solaris-x64/doc - - - staging/solaris-x64/include - - - staging/solaris-x64/installer - - - staging/solaris-x64/lib - - - staging/solaris-x64/scripts - - - staging/solaris-x64/share - - - ../resources/license.txt - - - staging/solaris-x64/server_3rd_party_licenses.txt - - - - - Program Files - ${installdir} - programfilessolaris-sparc - solaris-sparc - - - staging/solaris-sparc/bin - - - staging/solaris-sparc/doc - - - staging/solaris-sparc/include - - - staging/solaris-sparc/installer - - - staging/solaris-sparc/lib - - - staging/solaris-sparc/scripts - - - staging/solaris-sparc/stackbuilder - - - staging/solaris-sparc/share - - - ../resources/license.txt - - - staging/solaris-sparc/server_3rd_party_licenses.txt - - - @@ -1442,34 +1299,6 @@ - - server - ${system_temp_directory}/postgresql_installer_${random_number}/getlocales - programfileslinux-x64 - installer/server/getlocales - - - equals - ${platform_name} - linux-x64 - - - - - - server - ${system_temp_directory}/postgresql_installer_${random_number}/getlocales - programfileslinux-ppc64 - installer/server/getlocales - - - equals - ${platform_name} - linux-ppc - - - - server ${system_temp_directory}/postgresql_installer_${random_number}/getlocales.exe @@ -1484,34 +1313,6 @@ - - server - ${system_temp_directory}/postgresql_installer_${random_number}/getlocales - programfilessolaris-x64 - installer/server/getlocales - - - equals - ${platform_name} - solaris-intel - - - - - - server - ${system_temp_directory}/postgresql_installer_${random_number}/getlocales - programfilessolaris-sparc - installer/server/getlocales - - - equals - ${platform_name} - solaris-sparc - - - - @@ -1558,124 +1359,6 @@ - - - - server - ${system_temp_directory}/postgresql_installer_${random_number}/pg_controldata - programfileslinux-x64 - bin/pg_controldata - - - server - ${system_temp_directory}/postgresql_installer_${random_number}/runpgcontroldata.sh - programfileslinux-x64 - installer/server/runpgcontroldata.sh - - - - - equals - ${platform_name} - linux-x64 - - - - - - - - - server - ${system_temp_directory}/postgresql_installer_${random_number}/pg_controldata - programfileslinux-ppc64 - bin/pg_controldata - - - server - ${system_temp_directory}/postgresql_installer_${random_number}/runpgcontroldata.sh - programfileslinux-ppc64 - installer/server/runpgcontroldata.sh - - - server - ${system_temp_directory}/postgresql_installer_${random_number}/ - programfileslinux-ppc64 - lib - - - - - equals - ${platform_name} - linux-ppc - - - - - - - - - server - ${system_temp_directory}/postgresql_installer_${random_number}/pg_controldata - programfilessolaris-x64 - bin/pg_controldata - - - server - ${system_temp_directory}/postgresql_installer_${random_number}/runpgcontroldata.sh - programfilessolaris-x64 - installer/server/runpgcontroldata.sh - - - server - ${system_temp_directory}/postgresql_installer_${random_number}/ - programfilessolaris-x64 - lib - - - - - equals - ${platform_name} - solaris-intel - - - - - - - - - server - ${system_temp_directory}/postgresql_installer_${random_number}/pg_controldata - programfilessolaris-sparc - bin/pg_controldata - - - server - ${system_temp_directory}/postgresql_installer_${random_number}/runpgcontroldata.sh - programfilessolaris-sparc - installer/server/runpgcontroldata.sh - - - server - ${system_temp_directory}/postgresql_installer_${random_number}/ - programfilessolaris-sparc - lib - - - - - equals - ${platform_name} - solaris-sparc - - - - - From 5d12ff73bde47683c07d8f21d4b8480de47daf65 Mon Sep 17 00:00:00 2001 From: Semab-Tariq Date: Wed, 1 Dec 2021 13:40:18 +0500 Subject: [PATCH 4/4] [PPS-54] Restructure the code to fix some build time warnings by installbuilder --- server/commandlinetools.xml.in | 2 -- server/installer.xml.in | 42 +++++++++++++--------------------- server/pgserver.xml.in | 2 +- 3 files changed, 17 insertions(+), 29 deletions(-) diff --git a/server/commandlinetools.xml.in b/server/commandlinetools.xml.in index 9d5a13cb1..2587017ea 100755 --- a/server/commandlinetools.xml.in +++ b/server/commandlinetools.xml.in @@ -152,8 +152,6 @@ regexp - - diff --git a/server/installer.xml.in b/server/installer.xml.in index 7de4dae8d..80ae7bf23 100755 --- a/server/installer.xml.in +++ b/server/installer.xml.in @@ -2066,7 +2066,7 @@ ${dbsummary}${cltsummary}${pgadminsummary}${sbsummary}${msg(summary.installation Program Files ${installdir}/installer - defaultwindows-x64 + defaultwindows64 windows @@ -2196,15 +2196,6 @@ ${dbsummary}${cltsummary}${pgadminsummary}${sbsummary}${msg(summary.installation prefix 30 yes - - - ${iBaseDirectory} - empty - - - - - @@ -2215,6 +2206,7 @@ ${dbsummary}${cltsummary}${pgadminsummary}${sbsummary}${msg(summary.installation + @@ -2270,6 +2262,10 @@ ${dbsummary}${cltsummary}${pgadminsummary}${sbsummary}${msg(summary.installation + + ${iBaseDirectory} + empty + @@ -2315,16 +2311,6 @@ ${dbsummary}${cltsummary}${pgadminsummary}${sbsummary}${msg(summary.installation datadir 30 yes - - - ${iDataDirectory} - empty - - - - - - @@ -2332,6 +2318,7 @@ ${dbsummary}${cltsummary}${pgadminsummary}${sbsummary}${msg(summary.installation + @@ -2652,9 +2639,8 @@ ${dbsummary}${cltsummary}${pgadminsummary}${sbsummary}${msg(summary.installation - - - + + IsUpgrade 1 @@ -2674,7 +2660,7 @@ ${dbsummary}${cltsummary}${pgadminsummary}${sbsummary}${msg(summary.installation ^.*port\s*=\s*([\d]+)\s+.*$ \1 - + @@ -2721,6 +2707,11 @@ ${dbsummary}${cltsummary}${pgadminsummary}${sbsummary}${msg(summary.installation + + ${iDataDirectory} + empty + + @@ -3218,8 +3209,7 @@ ${dbsummary}${cltsummary}${pgadminsummary}${sbsummary}${msg(summary.installation - - + preinstallsummary ${msg(preinstall.summary)} diff --git a/server/pgserver.xml.in b/server/pgserver.xml.in index cd3bc0051..9bf7c6181 100755 --- a/server/pgserver.xml.in +++ b/server/pgserver.xml.in @@ -1417,7 +1417,7 @@ default ${system_temp_directory}\postgresql_installer_${random_number}\vcredist_x64.exe - defaultwindows-x64 + defaultwindows64 vcredist_x64.exe