-
Notifications
You must be signed in to change notification settings - Fork 248
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Edits to pgd_bench content #4789
Conversation
Please note I took all the tagging off of pgd_bench and pgbench for two reasons:
If you think these are commands rather than utilities/tools, I can put the tagging back. |
pgbench scenario to prevent global lock timeouts in certain cases. | ||
- `VACUUM` command in the standard scenario is executed on all nodes. | ||
- pgd_bench releases are tied to the releases of the BDR extension | ||
and are built against the corresponding PostgreSQL flavor. This is |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Postgres distribution (add link to the choosing your distribution page)
- No extra steps are taken to suppress client messages, such as `NOTICE` and `WARNING` messages emitted | ||
by PostgreSQL and or any possible extensions, including the BDR extension. It's your | ||
responsibility to suppress them by setting appropriate variables, such as `client_min_messages`, | ||
`bdr.camo_enable_client_warnings`, and so on. | ||
|
||
## Performance testing and tuning | ||
|
||
PGD allows you to issue write transactions onto multiple master nodes. Bringing |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
master --> leader?
|
||
First, replaying changes from another node has a CPU cost, an I/O cost, | ||
First, replaying changes from another node has a CPU cost an an I/O cost, | ||
and it generates WAL records. The resource use is usually less | ||
than in the original transaction since CPU overheads are lower as a result |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
CPU overhead is lower
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@ebgitelman I've left several suggestions - my main on is the use of PostgreSQL vs Postgres in this text - Let's try to use Postgres where possible
Changes applied, fixes made, new para pointing out pgd_bench is a wrapper around pgbench added. Re-review required. |
b7ae79e
to
fa3bc22
Compare
6ed43b4
to
df05c6f
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
0e55c45
to
fc0b2c5
Compare
It's not so much that but utilities are run with commands. So you need to have context. Where you are discussing the utility in general, so code formatting. But when you talk about invoking it, then code formatting. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Co-authored-by: Dj Walker-Morgan <[email protected]>
Co-authored-by: Dj Walker-Morgan <[email protected]>
fc0b2c5
to
23a6a68
Compare
What Changed?