Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Edits to pgd_bench content #4789

Merged
merged 6 commits into from
Oct 11, 2023
Merged

Conversation

ebgitelman
Copy link
Contributor

What Changed?

@ebgitelman ebgitelman requested a review from djw-m as a code owner September 7, 2023 20:46
@ebgitelman
Copy link
Contributor Author

Please note I took all the tagging off of pgd_bench and pgbench for two reasons:

  • For utilities, we're not using tagging.
  • They were inconsistent.

If you think these are commands rather than utilities/tools, I can put the tagging back.

pgbench scenario to prevent global lock timeouts in certain cases.
- `VACUUM` command in the standard scenario is executed on all nodes.
- pgd_bench releases are tied to the releases of the BDR extension
and are built against the corresponding PostgreSQL flavor. This is
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Postgres distribution (add link to the choosing your distribution page)

- No extra steps are taken to suppress client messages, such as `NOTICE` and `WARNING` messages emitted
by PostgreSQL and or any possible extensions, including the BDR extension. It's your
responsibility to suppress them by setting appropriate variables, such as `client_min_messages`,
`bdr.camo_enable_client_warnings`, and so on.

## Performance testing and tuning

PGD allows you to issue write transactions onto multiple master nodes. Bringing
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

master --> leader?


First, replaying changes from another node has a CPU cost, an I/O cost,
First, replaying changes from another node has a CPU cost an an I/O cost,
and it generates WAL records. The resource use is usually less
than in the original transaction since CPU overheads are lower as a result
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CPU overhead is lower

Copy link
Contributor

@kelpoole kelpoole left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ebgitelman I've left several suggestions - my main on is the use of PostgreSQL vs Postgres in this text - Let's try to use Postgres where possible

@djw-m djw-m requested review from kelpoole and djw-m September 8, 2023 09:24
@djw-m
Copy link
Contributor

djw-m commented Sep 8, 2023

Changes applied, fixes made, new para pointing out pgd_bench is a wrapper around pgbench added. Re-review required.

@djw-m djw-m force-pushed the docs/pgd-bench-edits-to_pr4530 branch from b7ae79e to fa3bc22 Compare September 8, 2023 09:50
@djw-m djw-m force-pushed the docs/pgd-bench-edits-to_pr4530 branch from 6ed43b4 to df05c6f Compare September 19, 2023 12:37
djw-m
djw-m previously approved these changes Sep 27, 2023
Copy link
Contributor

@djw-m djw-m left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

djw-m
djw-m previously approved these changes Sep 28, 2023
Copy link
Contributor

@djw-m djw-m left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@djw-m
Copy link
Contributor

djw-m commented Sep 28, 2023

Please note I took all the tagging off of pgd_bench and pgbench for two reasons:

* For utilities, we're not using tagging.

* They were inconsistent.

If you think these are commands rather than utilities/tools, I can put the tagging back.

It's not so much that but utilities are run with commands. So you need to have context. Where you are discussing the utility in general, so code formatting. But when you talk about invoking it, then code formatting.

Copy link
Contributor

@djw-m djw-m left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@josh-heyer josh-heyer force-pushed the docs/pgd-bench-edits-to_pr4530 branch from fc0b2c5 to 23a6a68 Compare October 11, 2023 04:32
@josh-heyer josh-heyer merged commit 7d2d14d into develop Oct 11, 2023
1 check passed
@josh-heyer josh-heyer deleted the docs/pgd-bench-edits-to_pr4530 branch October 11, 2023 04:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants