From 4207d153c50e5ff80a306e35fafc107dd40e5bee Mon Sep 17 00:00:00 2001 From: Chris Estes <106166814+ccestes@users.noreply.github.com> Date: Thu, 21 Sep 2023 17:30:19 -0400 Subject: [PATCH] Betsy feedback --- advocacy_docs/pg_extensions/spl_check/index.mdx | 2 +- advocacy_docs/pg_extensions/spl_check/using/tracer.mdx | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/advocacy_docs/pg_extensions/spl_check/index.mdx b/advocacy_docs/pg_extensions/spl_check/index.mdx index cd1b518dc34..d0c91ba5fe8 100644 --- a/advocacy_docs/pg_extensions/spl_check/index.mdx +++ b/advocacy_docs/pg_extensions/spl_check/index.mdx @@ -15,6 +15,6 @@ These are some of the key features of EDB SPL Check: - Identifies unused variables and function arguments as well as unmodified `OUT` arguments - Partially detects dead code, that is, code after an unqualified `RETURN` command - Detects missing `RETURN` commands in functions, which are common after exception handlers or complex logic -- Tries to identify unwanted hidden casts, which can be a performance issues like unused indexes +- Tries to identify unwanted hidden casts, which can cause performance issues like unused indexes - Collects relations and functions used by a function - Checks `EXECUTE` statements against SQL injection vulnerability \ No newline at end of file diff --git a/advocacy_docs/pg_extensions/spl_check/using/tracer.mdx b/advocacy_docs/pg_extensions/spl_check/using/tracer.mdx index 9b116ff6cc5..c0110c36509 100644 --- a/advocacy_docs/pg_extensions/spl_check/using/tracer.mdx +++ b/advocacy_docs/pg_extensions/spl_check/using/tracer.mdx @@ -28,7 +28,7 @@ To enable tracing, set `spl_check.tracer` to `on`. As a security safeguard, we recommend that the use of the tracer be enabled by a superuser by setting `spl_check.enable_tracer` to `on` or `spl_check.enable_tracer` to `on` in `postgresql.conf`. Because the tracer shows the content of EDB SPL Check's variables, some sensitive security information can display for an unprivileged user. -We also recommend that you load the extension `spl_check`. You can execute some `spl_check` functions explicitly with `load 'spl_check';`. You can use the configuration's `shared_preload_libraries`, `local_preload_libraries`, or `session_preload_libraries` option. +We also recommend that you load the extension `spl_check`. You can execute some `spl_check` functions explicitly with `load 'spl_check';`. You can also set the configuration options in `shared_preload_libraries`, `local_preload_libraries`, or `session_preload_libraries` options to load `spl_check`. In terse verbose mode, the output is reduced: