feat: format most commented elements #161
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
QuadnucYard
force-pushed
the
format-comments-3
branch
3 times, most recently
from
ec0c60a
to
cf5b2af
Compare
QuadnucYard
force-pushed
the
format-comments-3
branch
from
cf5b2af
to
2de8a57
Compare
Enter-tainer
approved these changes
Nov 28, 2024
There was a problem hiding this comment.
Overall LGTM. The idea of flow is fantastic.
Could you please also edit the changelog and the limitation doc to reflect latest changes? For example, https://enter-tainer.github.io/typstyle/limitations/#when-there-are-block-comment-child-gives-up-formatting-the-whole-node is no longer valid
QuadnucYard
force-pushed
the
format-comments-3
branch
from
2de8a57
to
373aba9
Compare
QuadnucYard
force-pushed
the
format-comments-3
branch
from
3612dc0
to
6a2fadc
Compare
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR makes the most elements formattable. The only untouched expressions are
Parenthesized,FieldAccess, andFuncCall, which have special treatment. Other elements are all marked formattable if not in math. No style change.Fixes a bug with destructuring introduced in #154. Destruct and params with line comments should not fold into one line.
We treat elements focused on in this PR as flow of items. They are joined by spaces (can be optional) or blocks, and no line break is allowed within.
We use a trick. When formatting these elements, we need not care about the syntax, but simply consider their types and make corresponding countermeasures. In some cases where Expr and Pattern coexist, we need to record the order.
The implementations are subject to change for simplicity and expressiveness.