Skip to content
This repository has been archived by the owner on Aug 8, 2023. It is now read-only.

Casing may cause bugs. #66

Open
georgercarder opened this issue Apr 13, 2022 · 0 comments
Open

Casing may cause bugs. #66

georgercarder opened this issue Apr 13, 2022 · 0 comments

Comments

@georgercarder
Copy link
Contributor

https://github.com/EnsoFinance/v1-core/blob/a0908c7121372b311924ab18fd19bcbb8aa31c04/lib/enso.ts#L268

Nit that could cause bugs:

It appears that all inputs to addAdapter are lower-case despite being comprised of multiple words.

This affects readability but also easily introduces bugs especially since these strings are not checked at compile (transpile) time.

Using camelCase to match the attributes they are shadowing seems to be the best strategy.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant