Skip to content
This repository has been archived by the owner on Aug 8, 2023. It is now read-only.

Implement threshold/timelock on rebalance #143

Closed
georgercarder opened this issue Jun 2, 2022 · 0 comments · Fixed by #221
Closed

Implement threshold/timelock on rebalance #143

georgercarder opened this issue Jun 2, 2022 · 0 comments · Fixed by #221

Comments

@georgercarder
Copy link
Contributor

georgercarder commented Jun 2, 2022

status: on hold to see if solutions from #121 would aide in the "donation" aspect of this vulnerability. Some work for the timelock was done here https://github.com/ensoFinance/v1-core/tree/george/code4rena/issue/143.

From https://github.com/code-423n4/2022-05-enso-findings/issues/198

Currently a manager can withdraw entire funds from a social strategy by iteratively calling rebalance atomically. See details in code4rena issue.

Consider their suggestions in designing mitigation including disallowing consecutive rebalances in the same tx, and measuring certain thresholds.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
1 participant