Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Header should be App Level rather than Page Level Only #724

Open
mehsaandev opened this issue Jul 22, 2024 · 0 comments
Open

Header should be App Level rather than Page Level Only #724

mehsaandev opened this issue Jul 22, 2024 · 0 comments
Assignees
Labels
p1 High priority

Comments

@mehsaandev
Copy link

I observed that in Mobile application we doesn't always need to use the same header in much of the screens, we make header of each screen as required and the main header in for the main Home page.
But unlike this, in web we use same navbar in almost all the except a few (e.g Login/SignUp, etc)
and currently we have to make the header in each and every screen seperatly, the best shot we have so far is we make a seperate widget for Header in the global widget section and call that Header in each page header property. but this is still at some redundant, right?
So how about if we make a new property of header for ViewGroup (because currently I didn't find header property in ViewGroup). We have Drawer, EndDrawer, Sidebar but not the Header. so if we make header property in ViewGroup then in case of all the Pages linked with Sidebar of viewgroup will have that Header option too I guess.
Well this solution won't fully accomplish all the usecases like if we have some pages that are not linked with sidebar but still uses same Navbar will require Navbar to be seperatly called.
But the idea is that we should reduce the redundancy of this in Ensemble React

@mehsaandev mehsaandev added the p1 High priority label Jul 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
p1 High priority
Projects
None yet
Development

No branches or pull requests

2 participants